Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hcal TDC fixes for upgrade relsease #1140

Merged
merged 2 commits into from Nov 1, 2013

Conversation

andersonjacob
Copy link
Contributor

These are the combined changes for the fixes to the Hcal TDC simulation and reconstruction. In addition to this code there needs to be a change to the customizer that turns off the time slewing at digitization.

process.mix.digitizers.hcal.doTimeSlew = False

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @andersonjacob for CMSSW_6_2_X_SLHC.

Hcal TDC fixes for upgrade relsease

It involves the following packages:

CalibCalorimetry/HcalAlgos
SimCalorimetry/HcalSimProducers
RecoLocalCalo/HcalRecProducers
RecoLocalCalo/HcalRecAlgos
CalibFormats/CaloObjects
SimCalorimetry/HcalSimAlgos

@smuzaffar, @civanch, @nclopezo, @demattia, @mdhildreth, @thspeer, @rcastello, @giamman, @slava77 can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@davidlange6 you are the release manager for this.

@abdoulline
Copy link

NB:
complementary SIM setting has to be included in SLHC customization for 2019 option
https://github.com/cms-sw/cmssw/blob/CMSSW_7_0_X/SLHCUpgradeSimulations/Configuration/python/HCalCustoms.py#L111

process.mix.digitizers.hcal.doTimeSlew = False

@cmsbuild
Copy link
Contributor

Pull request #1140 was updated. @smuzaffar, @civanch, @nclopezo, @demattia, @mdhildreth, @thspeer, @rcastello, @giamman, @slava77 can you please check and sign again.

@nclopezo
Copy link
Contributor

nclopezo commented Nov 1, 2013

tested with

runTheMatrix.py -w upgrade -l 3300,3400,4100,4400

Requested for CMSSW_6_2_0_SLHC3

nclopezo added a commit that referenced this pull request Nov 1, 2013
Hcal TDC fixes for upgrade relsease
@nclopezo nclopezo merged commit 6a0d78d into cms-sw:CMSSW_6_2_X_SLHC Nov 1, 2013
@andersonjacob andersonjacob deleted the HcalTDCFixSLHC branch May 21, 2014 18:25
epalencia added a commit to epalencia/cmssw that referenced this pull request Jun 28, 2023
Add updated caloParams for HI and ppRef
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants