Remove CaloGeometryRecord caching

[argiro]

Fix a rare crash in clustering

[cmsbuild]

A new Pull Request was created by @argiro for CMSSW_7_4_12_patchX.

Remove CaloGeometryRecord caching

It involves the following packages:

RecoParticleFlow/PFClusterProducer

@cmsbuild, @cvuosalo, @slava77 can you please review it and eventually sign? Thanks.
@mmarionncern, @bachtis, @lgray this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.

Note that this branch is designed for requested bug fixes specific to the CMSSW_7_4_12 release.
If you wish to make a pull request for the CMSSW_7_4_X release cycle, please use the CMSSW_7_4_X branch instead

[cvuosalo]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.

[cmsbuild]

Pull request #11414 was updated. @perrotta, @smuzaffar, @Dr15Jones, @cvuosalo, @fwyzard, @emeschi, @franzoni, @cerminar, @monttj, @Martin-Grunewald, @alja, @cmsbuild, @diguida, @deguio, @slava77, @mommsen, @vadler, @mmusich, @vanbesien, @mulhearn, @danduggan can you please check and sign again.

[lgray]

@cvuosalo unless something had changed tests don't run against the patchesX branch.

[slava77]

@argiro
Stefano
the fix should be done based on a recent 7_4_12_patch release (or, even the 7_4_12_patchX branch itself)

[argiro]

On 23 Sep 2015, at 05:59, Slava Krutelyov notifications@github.com wrote:

@argiro
Stefano
the fix should be done based on a recent 7_4_12_patch release (or, even the 7_4_12_patchX branch itself)

I did it based on 7_4_12_patch4, what is wrong exactly ?

—
Reply to this email directly or view it on GitHub.

[lgray]

Hi Stefano, the problem is that you used the same branch to make the CMSSW
7_4_X PR and the 7_4_patchX PR, and they are somewhat diverged at the
moment.

I would recommend that you take down the 7_4_X, rebase this branch and
update it using the commands I showed you yesterday except using
CMSSW_7_4_12_patchX instead of CMSSW_7_4_X, and then make a new branch that
you rebase to 7_4_X and then submit a new 7_4_X PR.

On Wed, Sep 23, 2015 at 9:22 AM, argiro notifications@github.com wrote:

On 23 Sep 2015, at 05:59, Slava Krutelyov notifications@github.com
wrote:

@argiro
Stefano
the fix should be done based on a recent 7_4_12_patch release (or, even
the 7_4_12_patchX branch itself)

I did it based on 7_4_12_patch4, what is wrong exactly ?

—
Reply to this email directly or view it on GitHub.

—
Reply to this email directly or view it on GitHub
#11414 (comment).

[argiro]

so #11414 is ok, but #11415 is not, correct ?

On 23 Sep 2015, at 09:44, Lindsey Gray notifications@github.com wrote:

Hi Stefano, the problem is that you used the same branch to make the CMSSW
7_4_X PR and the 7_4_patchX PR, and they are somewhat diverged at the
moment.

I would recommend that you take down the 7_4_X, rebase this branch and
update it using the commands I showed you yesterday except using
CMSSW_7_4_12_patchX instead of CMSSW_7_4_X, and then make a new branch that
you rebase to 7_4_X and then submit a new 7_4_X PR.

On Wed, Sep 23, 2015 at 9:22 AM, argiro notifications@github.com wrote:

On 23 Sep 2015, at 05:59, Slava Krutelyov notifications@github.com
wrote:

@argiro
Stefano
the fix should be done based on a recent 7_4_12_patch release (or, even
the 7_4_12_patchX branch itself)

I did it based on 7_4_12_patch4, what is wrong exactly ?

—
Reply to this email directly or view it on GitHub.

—
Reply to this email directly or view it on GitHub
#11414 (comment).

—
Reply to this email directly or view it on GitHub.

[lgray]

Right now 11414 is based on 7_4_X, since it shared the same branch as 11415.
You can see in 11415 that there is only one commit being brought in by the
PR, that's what we want to achieve for 11414.
However, it means you have to take down one of them and make a new PR based
on a new branch with the right history, since right now both PRs come from
the same branch.

On Wed, Sep 23, 2015 at 10:34 AM, argiro notifications@github.com wrote:

so #11414 is ok, but #11415 is not, correct ?

On 23 Sep 2015, at 09:44, Lindsey Gray notifications@github.com wrote:

Hi Stefano, the problem is that you used the same branch to make the
CMSSW
7_4_X PR and the 7_4_patchX PR, and they are somewhat diverged at the
moment.

I would recommend that you take down the 7_4_X, rebase this branch and
update it using the commands I showed you yesterday except using
CMSSW_7_4_12_patchX instead of CMSSW_7_4_X, and then make a new branch
that
you rebase to 7_4_X and then submit a new 7_4_X PR.

On Wed, Sep 23, 2015 at 9:22 AM, argiro notifications@github.com
wrote:

On 23 Sep 2015, at 05:59, Slava Krutelyov notifications@github.com
wrote:

@argiro
Stefano
the fix should be done based on a recent 7_4_12_patch release (or,
even
the 7_4_12_patchX branch itself)

I did it based on 7_4_12_patch4, what is wrong exactly ?

—
Reply to this email directly or view it on GitHub.

—
Reply to this email directly or view it on GitHub
#11414 (comment).

—
Reply to this email directly or view it on GitHub.

—
Reply to this email directly or view it on GitHub
#11414 (comment).

[argiro]

closing and rebasing