merge SLHC updates for CaloTowers

[kpedro88]

This PR updates the CaloTower geometry, topology, and algorithms to be consistent with the new HCAL geometry and topology code (followup on #10353). (Most of these changes are ported from 62XSLHC.)

A new parameter for calotowermaker is propagated to all the relevant HLT configs.

A few notes:

1. I already rebased this onto bsunanda:Run2-hcx28 Make the topology tester up-to-date with the geometry changes for HCAL #11423, to avoid a future (small) merge conflict.
2. The matrix tests will crash. This is expected because the new CaloTower geometry record is not in the database yet.
3. I validated this PR using 4.53 with the XML geometry, comparing clean CMSSW_7_6_X_2015-09-23-2300 to the same IB with this PR (using checkdeps). The output is identical, as expected; see plots below:

attn: @bsunanda, @ianna

[cmsbuild]

A new Pull Request was created by @kpedro88 (Kevin Pedro) for CMSSW_7_6_X.

merge SLHC updates for CaloTowers

It involves the following packages:

CondTools/Geometry
DQM/DataScouting
DataFormats/CaloTowers
Geometry/CaloEventSetup
Geometry/CaloGeometry
Geometry/CaloTopology
Geometry/EcalTestBeam
Geometry/HcalEventSetup
Geometry/HcalTowerAlgo
HLTrigger/Configuration
HLTrigger/HLTanalyzers
HLTrigger/JetMET
RecoEgamma/EgammaIsolationAlgos
RecoLocalCalo/CaloTowersCreator
RecoLocalCalo/HcalRecProducers
RecoParticleFlow/PFClusterProducer
RecoTauTag/RecoTau
SimDataFormats/EcalTestBeam

@perrotta, @cmsbuild, @civanch, @Dr15Jones, @cvuosalo, @fwyzard, @ianna, @mdhildreth, @Martin-Grunewald, @deguio, @slava77, @ggovi, @vanbesien, @danduggan can you please review it and eventually sign? Thanks.
@ghellwig, @apfeiffer1, @Sam-Harper, @mmarionncern, @argiro, @Martin-Grunewald, @jalimena, @lgray, @geoff-smith, @bachtis this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

[slava77]

changes in HLT table dump files are an instant "-1"
A fillDescriptions or a customize function need to be created

[kpedro88]

Hi Slava,

I made these changes because CaloTowersCreator has a new tracked parameter. The HLT python files make the config for calotowermaker manually, so the change needs to be propagated to all of them individually. If there is a better way to propagate this update, please let me know and I will update the PR.

[slava77]

Hi Kevin,
The best is to add fillDescriptions method to CaloTowersCreator and pass the new parameter there as a default.
A less desired alternative is HLTrigger/Configuration/python/customizeHLTforCMSSW.py

[kpedro88]

Hi Slava,
I'm not sure if fillDescriptions would work well in this case. Some of the HLT towermaker configs use different values for certain parameters (thresholds, etc.), and (if I understand correctly) those would have to be customized somewhere if fillDescriptions provided some set of default values.

I opted for the less obtrusive solution, setting a default value for HcalPhase if it's not present in the parameter set. The parameter is only used for upgrade studies, so it will never need to be set explicitly for Run 2.

[cmsbuild]

Pull request #11497 was updated. @perrotta, @cmsbuild, @civanch, @Dr15Jones, @cvuosalo, @fwyzard, @ianna, @mdhildreth, @Martin-Grunewald, @slava77, @ggovi can you please check and sign again.

[ianna]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.

[ianna]

@kpedro88 - is removing zdc here intentional?

[kpedro88]

@ianna - it looks like this was lost in the rebase. I'll fix it, thanks for the catch. (I'll also rewrite this part to use "else if" instead of nested if-else sets.)

[kpedro88]

These errors don't make sense to me:

An exception of category 'ConfigFileReadError' occurred while
   [0] Processing the python configuration file named /tmp/cmsbuild/workspace/ib-any-integration/CMSSW_7_6_X_2015-10-19-1100/src/TopQuarkAnalysis/TopEventProducers/test/tqaf_cfg.py
Exception Message:
python encountered the error: <type 'exceptions.ImportError'>
No module named CaloTowerTopology_cfi

CaloTowerTopology_cfi clearly exists in this PR. When I run that test locally, it works fine, and if I load the config interactively, I can see that it grabs the proper info from CaloTowerTopology_cfi:

python -i TopQuarkAnalysis/TopEventProducers/test/tqaf_cfg.py
>>> process.CaloTowerTopologyEP 
cms.ESProducer("CaloTowerTopologyEP")

Maybe it's just a spurious failure? It's never been a problem before. Let's try rerunning the tests...

[slava77]

@cmsbuild please test
[unclear why there would be a glitch]

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/9039/console

[slava77]

+1

for #11497 09ad091

• changes in the code look OK
• jenkins tests almost passed here, except for two odd errors in the unit tests; the equivalent 80X PR passed in full
• additionally tested locally in CMSSW_7_6_X_2015-10-19-1100 including tests with higher statistics: they confirm no differences in monitored quantities
  • the unit tests have passed locally in full

[ianna]

+1

[cmsbuild]

+1
Tested at: 09ad091
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11497/9039/summary.html

[mmusich]

+1
for kpedro88@d05559e

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11497/9039/summary.html

[civanch]

+1