Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update PFJetID for RunII, add ak8 MiniAOD monitoring, adopt ak4CHS JEC for type1 MET #11539

Closed
wants to merge 9 commits into from

Conversation

webermat
Copy link
Contributor

monitor substructure variables in JetMET DQM for ak8 jets. update PFJetID Selector to new recommended RunII JetID, move type1 corrections to ak4CHS JetEnergyCorrector.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @webermat for CMSSW_7_6_X.

update PFJetID for RunII, add ak8 MiniAOD monitoring, adopt ak4CHS JEC for type1 MET

It involves the following packages:

DQMOffline/JetMET
PhysicsTools/SelectorUtils
Validation/RecoMET

@danduggan, @monttj, @cmsbuild, @deguio, @vadler, @vanbesien can you please review it and eventually sign? Thanks.
@rappoccio, @ahinzmann, @mmarionncern, @jdolen, @nhanvtran, @schoef, @mariadalfonso, @TaiSakuma, @rociovilar this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@deguio
Copy link
Contributor

deguio commented Oct 7, 2015

more updates will come. waiting for now.

@webermat
Copy link
Contributor Author

added puppi jets and MET monitoring into JetMET Validation and DQM packages. Reduce number of bins in 2D plots and remove trigger stream folders.

@cmsbuild
Copy link
Contributor

Pull request #11539 was updated. @danduggan, @monttj, @cmsbuild, @deguio, @vadler, @vanbesien can you please check and sign again.

@webermat
Copy link
Contributor Author

please test

@davidlange6
Copy link
Contributor

cmsbuild, please test

@webermat
Copy link
Contributor Author

included MET filter monitoring for each of the recommended filters/or filters in testing face. Both PASS histograms and for each filter the efficiency. In order to free up memory all monitoring of OOT PU histograms for the 50ns beam spacing period is removed.

@cmsbuild
Copy link
Contributor

Pull request #11539 was updated. @danduggan, @monttj, @cmsbuild, @deguio, @vadler, @vanbesien can you please check and sign again.

@deguio
Copy link
Contributor

deguio commented Oct 28, 2015

please test

@deguio
Copy link
Contributor

deguio commented Oct 28, 2015

@webermat is this one final?
thanks,
F

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/9297/console

@deguio
Copy link
Contributor

deguio commented Nov 2, 2015

pleasae test

@deguio
Copy link
Contributor

deguio commented Nov 2, 2015

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 2, 2015

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/9420/console

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 2, 2015

Pull request #11539 was updated. @danduggan, @monttj, @cmsbuild, @deguio, @vadler, @vanbesien can you please check and sign again.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 2, 2015

-1
Tested at: e61080c
When I ran the RelVals I found an error in the following worklfows:
4.22 step1

DAS Error

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11539/9420/summary.html

@webermat
Copy link
Contributor Author

webermat commented Nov 3, 2015

the error doesn't seem to be related to the update, but it affects workflow 4.22, which failed previously (cosmics).
The second workflow 8.0 (BeamHalo) which failed previously, runs without any problems. Since both of those run the (fixed) cosmic sequence, workflow 4.22 should finish successfully too.

@deguio
Copy link
Contributor

deguio commented Nov 10, 2015

please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/9624/console

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@deguio
Copy link
Contributor

deguio commented Nov 10, 2015

would like to wait and see how it goes the validation in 80x first

@deguio
Copy link
Contributor

deguio commented Nov 19, 2015

+1

@webermat
Copy link
Contributor Author

concerning the comparisons, it seems when running the matrix that HBHENoiseFilterFlag is always false in MINAOD, but when running on all available MINIAOD RelVals (both 76X and 80X) the flag is correctly filled and the plots appear to be fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants