Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New GT for re-reco fixing issues with HCAL and ECAL tags. #11567

Merged
merged 1 commit into from Sep 30, 2015

Conversation

diguida
Copy link
Contributor

@diguida diguida commented Sep 30, 2015

Summary of changes

Run1 data

74X_dataRun1_v3: as 74X_dataRun1_v2 with the following changes:

  • taxonomy change for Muon APE
  • added BTV discriminators as GBRForest payloads with new labels
  • updated SiStrip O2O conditions: now using prompt version. BEWARE: Noise tag must be reviewed: keeping the old offline version
  • updated ECAL pulse shapes with Run2 values (Run1 value kepts as MC in the first IOV)
  • updated HCAL electronic maps in order to unpack all HF FED
  • updated HCAL response corrections with the latest scale computed in the Early Commissioning studies.

Run2 data

74X_dataRun2_v3: as 74X_dataRun2_v2 with the following changes:

  • taxonomy change for Muon APE
  • added BTV discriminators as GBRForest payloads with new labels
  • updated SiStrip O2O conditions: now using prompt version. BEWARE: Noise tag must be reviewed: keeping the old offline version
  • updated ECAL pulse shapes with Run2 values (Run1 value kepts as MC in the first IOV)
  • updated HCAL electronic maps in order to unpack all HF FED
  • updated HCAL response corrections with the latest scale computed in the Early Commissioning studies.

@diguida
Copy link
Contributor Author

diguida commented Sep 30, 2015

@cmsbuild please test

@mmusich
Copy link
Contributor

mmusich commented Sep 30, 2015

For the record: should fix the HF unpacker issue shown in the validation report by @hengne here

@cmsbuild cmsbuild added this to the Next CMSSW_7_4_X milestone Sep 30, 2015
@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @diguida (Salvatore Di Guida) for CMSSW_7_4_X.

New GT for re-reco fixing issues with HCAL and ECAL tags.

It involves the following packages:

Configuration/AlCa

@cmsbuild, @mmusich, @diguida, @franzoni, @cerminar can you please review it and eventually sign? Thanks.
@ghellwig, @Martin-Grunewald this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@diguida
Copy link
Contributor Author

diguida commented Sep 30, 2015

@slava77 this is something you might want to watch as well.

@diguida
Copy link
Contributor Author

diguida commented Sep 30, 2015

@abdoulline this is something you might want to watch as well.

@cmsbuild
Copy link
Contributor

@mmusich
Copy link
Contributor

mmusich commented Sep 30, 2015

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_7_6_X is complete. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

davidlange6 added a commit that referenced this pull request Sep 30, 2015
New GT for re-reco fixing issues with HCAL and ECAL tags.
@davidlange6 davidlange6 merged commit 99c1681 into cms-sw:CMSSW_7_4_X Sep 30, 2015
@cmsbuild
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants