CalibCalorimetry/EcalLaserAnalyzer: uncomment ClassDef

[davidlt]

Having classes based on TObject without ClassDef creates issues while
creating a dictionary. According to CVS these files were introduced 6
years and 4 months ago and already had ClassDef commented out. If we
do not need to store (I/O) then we need to set ClassVersionID to 0.

CVS history: http://cvs.web.cern.ch/cvs/cgi-bin/viewcvs.cgi/CMSSW/CalibCalorimetry/EcalLaserAnalyzer/interface/
ROOT ClassDef documentation: https://root.cern.ch/root/Using.html

Signed-off-by: David Abdurachmanov David.Abdurachmanov@cern.ch

[davidlt]

Basically with is RFC. It's up to L2 to decide if these classes requires IO or not, if not we probably don't need this dictionary (?).

@wmtan

[cmsbuild]

A new Pull Request was created by @davidlt for CMSSW_7_6_X.

CalibCalorimetry/EcalLaserAnalyzer: uncomment ClassDef

It involves the following packages:

CalibCalorimetry/EcalLaserAnalyzer

@cmsbuild, @mmusich, @diguida, @franzoni, @cerminar can you please review it and eventually sign? Thanks.
@argiro this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

[mmusich]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/8836/console

[cmsbuild]

-1
Tested at: 5a5f7f1
you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11787/8836/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
23fc7e2
f190bfc
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11787/8836/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11787/8836/git-merge-result

[diguida]

please test
failures unrelated to this PR

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/8840/console

[davidlt]

Before this is merged I would like to see a statement regarding ClassVersionID. Do we need object I/O or not.

[cmsbuild]

-1
Tested at: 5a5f7f1
you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11787/8840/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
23fc7e2
f190bfc
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11787/8840/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11787/8840/git-merge-result

[smuzaffar]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/8845/console

[cmsbuild]

+1
Tested at: 5a5f7f1
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11787/8845/summary.html

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11787/8845/summary.html

[davidlt]

Could we resolve this, this is blocking building with ROOT 6.04 / 6.06. So, do we need object I/O here or not? If yes, then this PR stays as-is, I guess. If not, I will create a different PR.

[davidlt]

ping^1

[davidlt]

Closed for CMSSW_7_6_X, look at PR for CMSSW_8_0_X.