configuring flat BS + DQM GUI

[boudoul]

this PR is changing two files :

• MatrixInjector : the testbed for DQM GUI is now deprecated , relvals should be submitted without the testbed (aligned to 7X)
• combinedCustoms.py : there is the request from upgrade to have samples with a flat BS at 3 different length - So far only 11 cm was configured - Now we can have 11, 15, and 20 with the modified customs.
  None of the workflows are configured with the flat BS , the samples will be produced by calling specifically the news customs

[cmsbuild]

A new Pull Request was created by @boudoul (boudoul) for CMSSW_6_2_X_SLHC.

configuring flat BS + DQM GUI

It involves the following packages:

Configuration/PyReleaseValidation
SLHCUpgradeSimulations/Configuration

@civanch, @danduggan, @boudoul, @franzoni, @mdhildreth, @fabozzi, @cmsbuild, @srimanob can you please review it and eventually sign? Thanks.
@ghellwig, @makortel, @Martin-Grunewald this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@fratnikov, @mark-grimes you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

[mark-grimes]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/8985/console

[cmsbuild]

+1
Tested at: 8d7f617
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11868/8985/summary.html

[mark-grimes]

The automatic tests don't use the added functions so I tried a few quick checks privately. If I do:

cmsDriver.py FourMuPt_1_200_cfi  --conditions PH2_1K_FB_V6::All -n 10 --eventcontent FEVTDEBUG --relval 10000,100 -s GEN,SIM --datatier GEN-SIM --beamspot HLLHC --customise SLHCUpgradeSimulations/Configuration/combinedCustoms.cust_2023HGCalMuon,SLHCUpgradeSimulations/Configuration/combinedCustoms.customise_bsStudyStep1_15 --geometry Extended2023HGCalMuon,Extended2023HGCalMuonReco --magField 38T_PostLS1 --fileout file:step1.root

(basically runTheMatrix.py -w upgrade -l 12200 but with the new customisation added) I get:

TypeError: MaxZ does not already exist, so it can only be set to a CMS python configuration type

One other thought - rather than separate "step1" and "step2" functions, would it be easier to have one function with sections protected by hasattr guards? It would be a bit cleaner and I imagine easier to use, e.g. runTheMatrix can be given one --command="--customise=<...>" command, rather than having to apply different functions to each step. I guess it depends on how the samples are injected, so @boudoul if you prefer this way that's fine.

[boudoul]

Right , as it is now (it was already like that before even without this change) I set a different customize for gensim and reco step _ I agree it would be better to put sections with hasattr slection . I fear I won't have time to configure this today , so if unless you can do it's fine, but otherwise no pb for me to injection with different customize according to the step

[mark-grimes]

Okay. For the TypeError shall I add the types or am I using it incorrectly, e.g. maybe it's only ever used with another customisation that sets the type initially?

[boudoul]

ok let me reproduce to see if I really screwed up or if it's just a matter of the way of handling this customize, come back to you in ~1h

[boudoul]

Got it :
the customize is for the flat BS , not the gaussian one (HLLHC) so to make the WFs running, one should also modify the beamspot option :
from --beamspot HLLHC to --beamspot Flat

so to test (i just did it with the last IB + this PR on top of it ) the cmsdriver commands are :

cmsDriver.py FourMuPt_1_200_cfi --conditions PH2_1K_FB_V6::All -n 1 --eventcontent FEVTDEBUG --relval 10000,100 -s GEN,SIM --datatier GEN-SIM --beamspot Flat --customise SLHCUpgradeSimulations/Configuration/combinedCustoms.cust_2023HGCalMuon,SLHCUpgradeSimulations/Configuration/combinedCustoms.customise_bsStudyStep1_15 --geometry Extended2023HGCalMuon,Extended2023HGCalMuonReco --magField 38T_PostLS1 --fileout file:step1.root
--> note the new beamspot and the new customize with respect to 12200

cmsDriver.py step2 --conditions PH2_1K_FB_V6::All -n 10 --eventcontent FEVTDEBUGHLT -s DIGI:pdigi_valid,L1,DIGI2RAW --datatier GEN-SIM-DIGI-RAW --customise SLHCUpgradeSimulations/Configuration/combinedCustoms.cust_2023HGCalMuon --geometry Extended2023HGCalMuon,Extended2023HGCalMuonReco --magField 38T_PostLS1 --filein file:step1.root

--> nothing changed with respect to 12200

cmsDriver.py step3 --conditions PH2_1K_FB_V6::All -n 10 --eventcontent RECOSIM -s RAW2DIGI,L1Reco,RECO --datatier GEN-SIM-RECO --customise SLHCUpgradeSimulations/Configuration/combinedCustoms.cust_2023HGCalMuon,SLHCUpgradeSimulations/Configuration/combinedCustoms.customise_bsStudyStep2_15 --geometry Extended2023HGCalMuon,Extended2023HGCalMuonReco --magField 38T_PostLS1 --filein file:step2_DIGI_L1_DIGI2RAW.root

--> note the new customize with respect to 12200

[boudoul]

so in conclusion to me, it looks fine