Changed class statics to const member data to fix thread-safety issues #1193
Conversation
The thread-safety checker complained about the non-const statics which were being used to hold configuration information. These were easily changed to const member data instead.
|
A new Pull Request was created by @Dr15Jones (Chris Jones) for CMSSW_7_0_X. Changed class statics to const member data to fix thread-safety issues It involves the following packages: RecoLocalMuon/DTRecHit @nclopezo, @smuzaffar, @thspeer, @slava77 can you please review it and eventually sign? Thanks. |
|
Does not seem to merge anymore. |
Similar changes where already done to fix the statics. However, I prefer this solutions since I was able to make the member data const which more clearly states their purpose.
|
Pull request #1193 was updated. @nclopezo, @smuzaffar, @thspeer, @slava77 can you please check and sign again. |
|
+1 |
|
This pull request is fully signed and it will be integrated in one of the next IBs unless changes or unless it breaks tests. @ktf can you please take care of it? |
Multithreading fixes -- Changed class statics to const member data to fix thread-safety issues
Add Phase-2 Level-1 trigger ML MET emulator [14_0_0_pre3]
The thread-safety checker complained about the non-const statics which
were being used to hold configuration information. These were easily
changed to const member data instead.