Validation modules for ME0 Detector (Phase2 Upgrade) #11941

cmsbuild · 2015-10-19T08:18:29Z

Validation modules for ME0 Detector (Phase2 Upgrade)

This PR include Validation/MuonME0Hits, MuonME0Digis, MuonME0RecHits module to validate ME0 simulation.

MuonGEMHits module is related to SimHit on ME0 Detector.
MuonGEMDigis module is related to Digi step about ME0.
MuonGEMRecHits module is related both to ME0 RecHits and ME0 Segments.

This PR does not affect other modules.

These module are only run by a specific customize options. (Validation/MuonME0Hits/python/me0Custom.py)
Automatically ported from CMSSW_7_6_X #11461 (original by @clacaputo).

Compilation --> OK Run --> Not already tested - Validation/MuonME0Hits/interface/ME0BaseValidation.* Abstract Class for the ME0 validation packages - Validation/MuonME0Hits/src/ME0HitsValidation.* Book histos, loop on simHits, fill histos - Validation/MuonME0Hits/plugins/MuonME0HitsValidator.cc Plugin definition - Validation/MuonME0Hits/python/MuonME0Hits_cfi.py PSet for the ME0HitsValidation module

Compilatio -->OK Run --> toBe tested new file: Validation/MuonME0Digis/interface/ME0DigisValidation.h new file: Validation/MuonME0Digis/src/ME0DigisValidation.cc - Inherited from ME0BaseValidation class

Compilation --> OK Testing --> NO Structure of the package Validation/MuonME0RecHits is similar to the digi packages. modified: SLHCUpgradeSimulations/Configuration/python/fixMissingUpgradeGTPayloads.py - "connect" parameter changed to "untracked" in "fixRPCConditions" new file: Validation/MuonME0Hits/test/Generate.sh - collection of "cmsDriver.py" commands for the GEN-SIM-DIGI step, Validation step and Harvest Step

Compiling ----> Ok running ----> Ok

cmsbuild · 2015-10-19T08:24:05Z

A new Pull Request was created by @cmsbuild for CMSSW_8_0_X.

Validation modules for ME0 Detector (Phase2 Upgrade)

It involves the following packages:

Validation/MuonME0Digis
Validation/MuonME0Hits
Validation/MuonME0RecHits

The following packages do not have a category, yet:

Validation/MuonME0Digis
Validation/MuonME0Hits
Validation/MuonME0RecHits

@cmsbuild can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

deguio · 2015-11-16T14:01:28Z

please test

cmsbuild · 2015-11-16T14:07:10Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/9746/console

cmsbuild · 2015-11-16T16:10:10Z

-1
Tested at: cf0a3e2
I found a compilation error while trying to compile with clang:
I used this command:
scram b vclean && scram build -k -j 8 USER_CXXFLAGS='-fsyntax-only' COMPILER='llvm compile'

Entering library rule at src/Validation/MuonME0Digis/plugins
>> Compiling  /tmp/cmsbuild/workspace/ib-any-integration/CMSSW_8_0_X_2015-11-15-2300/src/Validation/MuonME0RecHits/src/ME0RecHitsValidation.cc 
>> Compiling  /tmp/cmsbuild/workspace/ib-any-integration/CMSSW_8_0_X_2015-11-15-2300/src/Validation/MuonME0RecHits/src/ME0SegmentsValidation.cc 
Entering library rule at src/Validation/MuonME0RecHits/plugins
>> Compiling edm plugin /tmp/cmsbuild/workspace/ib-any-integration/CMSSW_8_0_X_2015-11-15-2300/src/Validation/MuonME0Hits/plugins/MuonME0HitsValidator.cc 
/tmp/cmsbuild/workspace/ib-any-integration/CMSSW_8_0_X_2015-11-15-2300/src/Validation/MuonME0Hits/src/ME0HitsValidation.cc:87:23: error: unused variable 'Gp0' [-Werror,-Wunused-variable]
    const GlobalPoint Gp0(ME0Geometry_->idToDet(hits->detUnitId())->surface().toGlobal(p0));
                      ^
/tmp/cmsbuild/workspace/ib-any-integration/CMSSW_8_0_X_2015-11-15-2300/src/Validation/MuonME0Hits/src/ME0HitsValidation.cc:96:22: error: unused variable 'hitEP' [-Werror,-Wunused-variable]
    const LocalPoint hitEP(hits->entryPoint());
                     ^

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11941/9746/summary.html

cmsbuild · 2015-11-16T17:20:41Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11941/9746/summary.html

deguio · 2015-11-19T10:25:56Z

-1
to be fixed

cmsbuild · 2015-12-15T17:35:49Z

Pull request #11941 was updated. @cmsbuild, @vanbesien, @deguio, @davidlange6 can you please check and sign again.

clacaputo · 2015-12-15T17:37:50Z

Dear @deguio, I've just updated the code following your suggestions. Could you please trigger the test?
Thanks

deguio · 2015-12-16T14:42:16Z

please test

cmsbuild · 2015-12-16T14:42:38Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/10324/console

cmsbuild · 2015-12-16T17:06:17Z

+1
Tested at: b3716d1
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11941/10324/summary.html

cmsbuild · 2015-12-16T18:06:08Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11941/10324/summary.html

deguio · 2015-12-17T13:52:00Z

+1

cmsbuild · 2015-12-17T13:52:19Z

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

davidlange6 · 2015-12-23T14:01:26Z

@ciacaputo, @deguio - sorry for my slow review - this all looks good, however could you put it in one instead of 3 new packages? Thanks!

clacaputo · 2016-01-08T11:50:51Z

Dear @davidlange6, I split the validation in three different packages because this is the usual structure already implemented in the other subdetector validation packages. Should I move to the "one-package" solution or I could keep the "three-packages" solution?

calabria · 2016-01-14T12:41:51Z

Please @davidlange6 let us know what you prefer to do here, this PR is pending since long time and we need to have it included in 800. Thanks a lot.

davidlange6 · 2016-01-14T13:27:02Z

@calabria @clacaputo - sorry to not answer - please stick to one package. Thanks!

clacaputo · 2016-01-14T15:46:56Z

Dear @davidlange6 , should I make a new PR with the one-package solution? Or simply push to ME0_DQM_Validation_Porting_76X ? Thanks.

davidlange6 · 2016-01-14T17:37:13Z

@clacaputo - it looks like you will need to open a new PR as this one is owned by cmsbuild (you can just modify your old branch if you still have it)

davidlange6 · 2016-01-22T22:03:35Z

I will close this PR while a new one is made by @clacaputo

clacaputo added 8 commits June 5, 2015 16:04

Modification to zR occupancy plots

c5ba627

Customs file for the me0 validation sequences

88fb7cd

ME0Digis Validation Package, first implementation

e6e62ee

Compilatio -->OK Run --> toBe tested new file: Validation/MuonME0Digis/interface/ME0DigisValidation.h new file: Validation/MuonME0Digis/src/ME0DigisValidation.cc - Inherited from ME0BaseValidation class

Merged ME0_DQM_Validation_porting_75X from repository clacaputo

6d2219f

ME0 Segment and RH package

7879083

Compiling ----> Ok running ----> Ok

Segmente Timing plots added

4d982df

cmsbuild added this to the Next CMSSW_8_0_X milestone Oct 19, 2015

cmsbuild added pending-signatures tests-pending orp-pending new-package-pending comparison-pending labels Oct 19, 2015

BuildFile and headers clenup

cf0a3e2

cmsbuild added dqm-pending and removed new-package-pending labels Nov 13, 2015

cmsbuild added tests-started and removed tests-pending labels Nov 16, 2015

cmsbuild added tests-rejected and removed tests-started labels Nov 16, 2015

cmsbuild added comparison-available and removed comparison-pending labels Nov 16, 2015

cmsbuild removed the dqm-pending label Nov 19, 2015

cmsbuild added tests-pending comparison-pending and removed tests-approved labels Dec 15, 2015

cmsbuild added tests-started and removed tests-pending labels Dec 16, 2015

cmsbuild added tests-approved and removed tests-started labels Dec 16, 2015

cmsbuild added comparison-available and removed comparison-pending labels Dec 16, 2015

cmsbuild added dqm-approved fully-signed and removed dqm-pending pending-signatures labels Dec 17, 2015

davidlange6 closed this Jan 22, 2016

deguio mentioned this pull request Mar 24, 2016

Validation module for ME0 Detector (Phase2 Upgrade) #13347

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Validation modules for ME0 Detector (Phase2 Upgrade) #11941

Validation modules for ME0 Detector (Phase2 Upgrade) #11941

cmsbuild commented Oct 19, 2015

cmsbuild commented Oct 19, 2015

deguio commented Nov 16, 2015

cmsbuild commented Nov 16, 2015

cmsbuild commented Nov 16, 2015

cmsbuild commented Nov 16, 2015

deguio commented Nov 19, 2015

cmsbuild commented Dec 15, 2015

clacaputo commented Dec 15, 2015

deguio commented Dec 16, 2015

cmsbuild commented Dec 16, 2015

cmsbuild commented Dec 16, 2015

cmsbuild commented Dec 16, 2015

deguio commented Dec 17, 2015

cmsbuild commented Dec 17, 2015

davidlange6 commented Dec 23, 2015

clacaputo commented Jan 8, 2016

calabria commented Jan 14, 2016

davidlange6 commented Jan 14, 2016

clacaputo commented Jan 14, 2016

davidlange6 commented Jan 14, 2016

davidlange6 commented Jan 22, 2016

Validation modules for ME0 Detector (Phase2 Upgrade) #11941

Validation modules for ME0 Detector (Phase2 Upgrade) #11941

Conversation

cmsbuild commented Oct 19, 2015