Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

push V0Producer from 75X and 76X into 74X #11974

Merged
merged 1 commit into from Oct 22, 2015
Merged

push V0Producer from 75X and 76X into 74X #11974

merged 1 commit into from Oct 22, 2015

Conversation

fojensen
Copy link
Contributor

same additions as those in two previous pull requests to different release versions:
#11660
#11699

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @fojensen (Frank Jensen) for CMSSW_7_4_X.

push V0Producer from 75X and 76X into 74X

It involves the following packages:

RecoVertex/V0Producer

@cmsbuild, @cvuosalo, @slava77 can you please review it and eventually sign? Thanks.
@makortel, @GiacomoSguazzoni, @rovere, @VinInn, @cerati, @dgulhan this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@slava77
Copy link
Contributor

slava77 commented Oct 20, 2015

@cmsbuild please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/9038/console

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@slava77
Copy link
Contributor

slava77 commented Oct 21, 2015

+1

for #11974 c024fb6

  • new options/selections added to V0 reco; needed for HI HLT filter development; defaults for regular reco leave it unchanged
  • the same code differences as in 76X and 75X
  • jenkins test pass and comparisons with baseline show no differences

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_7_6_X is complete. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request Oct 22, 2015
push V0Producer from 75X and 76X into 74X
@cmsbuild cmsbuild merged commit 62442e2 into cms-sw:CMSSW_7_4_X Oct 22, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants