Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reduce() is not a builtin in python 3 #12007

Merged
merged 1 commit into from Oct 26, 2015

Conversation

ericvaandering
Copy link
Contributor

See https://docs.python.org/2/library/functools.html

moved to functools as of python 2.6.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @ericvaandering (Eric Vaandering) for CMSSW_8_0_X.

reduce() is not a builtin in python 3

It involves the following packages:

CondCore/TagCollection
Configuration/Applications
DQM/Integration
Documentation/DataFormats
HLTriggerOffline/Egamma
RecoLuminosity/LumiDB
Utilities/RelMon
Validation/Performance
Validation/Tools

@smuzaffar, @diguida, @danduggan, @cvuosalo, @cmsdoxy, @cerminar, @cmsbuild, @franzoni, @Dr15Jones, @deguio, @slava77, @ggovi, @mmusich, @vanbesien, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @apfeiffer1, @batinkov, @wddgit, @Martin-Grunewald, @threus this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@Dr15Jones
Copy link
Contributor

Please test

@Dr15Jones
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/9096/console

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@slava77
Copy link
Contributor

slava77 commented Oct 21, 2015

+1

for #12007 00f5de7

  • changes are as described
  • jenkins tests pass and comparisons with baseline show no differences

davidlange6 added a commit that referenced this pull request Oct 26, 2015
reduce() is not a builtin in python 3
@davidlange6 davidlange6 merged commit 932cf44 into cms-sw:CMSSW_8_0_X Oct 26, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants