Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add eras for 2016 and Run 1 #12023

Merged
merged 3 commits into from Oct 26, 2015

Conversation

mark-grimes
Copy link

This adds a Run2_2016 era that uses the stage 2 trigger. The stage2L1Trigger sub-era component of it is currently empty, but I'm expecting trigger experts to apply the correct commands.

A Run1 era is also added. This is foreseen as a no-operation era to help with scripting cmsDriver commands (e.g. --era=$MY_ERA). However, it also adds the flexibility to add customisation changes at a later date.

Both of these additions were discussed in the 20/Oct/2015 release planning meeting.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mark-grimes (Mark Grimes) for CMSSW_8_0_X.

Add eras for 2016 and Run 1

It involves the following packages:

Configuration/StandardSequences

@cmsbuild, @franzoni, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @makortel, @GiacomoSguazzoni, @rovere, @VinInn, @Martin-Grunewald, @cerati, @dgulhan this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@Martin-Grunewald
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/9119/console

@cmsbuild
Copy link
Contributor

The jenkins tests job failed, please try again.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/9119/console

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@davidlange6
Copy link
Contributor

@mark-grimes - thinking outloud - is changing run2 to 2015 a big deal at this point?

@mark-grimes
Copy link
Author

You mean changing the name? Not really, git grep should easily point out all occurrences. The only thing is that it would introduce a lot of merge conflicts for things in the queue if people have started using them.

@davidlange6
Copy link
Contributor

@mark-grimes - right - maybe this can be done purely within cms driver, as for most people, 2015 and 2016 (and 2017 and 2018) will be the same "run2". Also, we should do this in 76x together with adding a run1 era.

@mark-grimes
Copy link
Author

I'm confused what you mean about doing it in cmsDriver. If that decision is hidden from the user then there would have to be some analysis of the input file to decide which year/scenario it's from and hence which era to activate.

Whatever happens, PRs in 7_6_X are automatically forward ported to 8_0_X, so I should close this one right?

davidlange6 added a commit that referenced this pull request Oct 26, 2015
@davidlange6 davidlange6 merged commit 3151b50 into cms-sw:CMSSW_8_0_X Oct 26, 2015
@mark-grimes mark-grimes deleted the add2016AndRun1Eras branch October 26, 2015 13:41
@mark-grimes
Copy link
Author

7_6_X version is #12117.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants