Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

turn FTSFromVertexToPointFactory::operator() into a static method #1203

Merged

Conversation

fwyzard
Copy link
Contributor

@fwyzard fwyzard commented Oct 28, 2013

FTSFromVertexToPointFactory does not have any data members, and a single (currently non-const) method, FTSFromVertexToPointFactory::operator() .
This patch changes that single method into a static method, FTSFromVertexToPointFactory::get(), and propagates the change to downstream code.

FTSFromVertexToPointFactory does not have any data members, and a single (currently non-const) method, FTSFromVertexToPointFactory::operator() .
This patch changes that single method into a static method, FTSFromVertexToPointFactory::get(), and propagates the change to downstream code.
@fwyzard
Copy link
Contributor Author

fwyzard commented Oct 28, 2013

+1

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @fwyzard (Andrea Bocci) for CMSSW_7_0_X.

turn FTSFromVertexToPointFactory::operator() into a static method

It involves the following packages:

RecoEgamma/Examples
HLTrigger/Egamma
RecoEgamma/EgammaElectronAlgos

@nclopezo, @smuzaffar, @thspeer, @slava77 can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@ktf you are the release manager for this.

@nclopezo
Copy link
Contributor

@thspeer
Copy link
Contributor

thspeer commented Oct 29, 2013

+1
Tested 276b8e8 in CMSSW_7_0_X_2013-10-28-0200
No difference in reco as expected, based on RelMon and reco script

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IBs unless changes or unless it breaks tests. @ktf can you please take care of it?

ktf added a commit that referenced this pull request Oct 29, 2013
…y_static

Multithreading fixes -- turn FTSFromVertexToPointFactory::operator() into a static method
@ktf ktf merged commit 786f815 into cms-sw:CMSSW_7_0_X Oct 29, 2013
@fwyzard fwyzard deleted the make_FTSFromVertexToPointFactory_static branch November 3, 2013 15:44
NJManganelli pushed a commit to NJManganelli/cmssw that referenced this pull request Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants