Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set ROOT histogram fitting to be thread-safe #12033

Merged
merged 1 commit into from Oct 27, 2015

Conversation

Dr15Jones
Copy link
Contributor

In order to fit different root histograms on different threads one
must call the undocumented function TMinuitMinimizer::UseStaticMinuit
and pass it false.
This will fix crashes seen in the CMSSW_7_6 IBs.

In order to fit different root histograms on different threads one
must call the undocumented function TMinuitMinimizer::UseStaticMinuit
and pass it false.
This will fix crashes seen in the CMSSW_7_6 IBs.
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @Dr15Jones (Chris Jones) for CMSSW_7_5_X.

Set ROOT histogram fitting to be thread-safe

It involves the following packages:

RecoHI/HiTracking

@cmsbuild, @cvuosalo, @slava77 can you please review it and eventually sign? Thanks.
@jazzitup, @dgulhan, @echapon, @yenjie, @kurtejung, @istaslis, @mandrenguyen, @richard-cms, @yetkinyilmaz this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@Dr15Jones
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/9115/console

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@cvuosalo
Copy link
Contributor

+1

For #12033 15a24e3

Fix to make ROOT histogram fitting thread-safe to prevent crashes. There should be no change in monitored quantities. #12031 and #12032 are the 76X and 80X versions of this PR, and ithey've already been approved by Reco.

The code change is satisfactory, and Jenkins tests against baseline CMSSW_7_5_X_2015-10-21-1100 show no significant differences, as expected.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_7_6_X is complete. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request Oct 27, 2015
Set ROOT histogram fitting to be thread-safe
@cmsbuild cmsbuild merged commit e9392d8 into cms-sw:CMSSW_7_5_X Oct 27, 2015
@Dr15Jones Dr15Jones deleted the makeHistFitThreadSafe_7_5 branch December 8, 2015 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants