New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed LazyGetter from SiPixelClusterShapeCache #12035
Removed LazyGetter from SiPixelClusterShapeCache #12035
Conversation
The original LazyGetter implementation was not thread-safe and the facility was never used in production. Removing the code avoids accidently trying to switch on that facility. The SiPixelClusterShapeCacheProducer was also switch from a stream producer to a global producer.
A new Pull Request was created by @Dr15Jones (Chris Jones) for CMSSW_8_0_X. Removed LazyGetter from SiPixelClusterShapeCache It involves the following packages: DataFormats/SiPixelCluster @cmsbuild, @cvuosalo, @slava77 can you please review it and eventually sign? Thanks. |
please test |
@makortel As we discussed I've removed the LazyGetter facility. |
The tests are being triggered in jenkins. |
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
+1
@fwyzard @Martin-Grunewald in case you are not subscribed |
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar |
+1 |
…lusterShapeCache Removed LazyGetter from SiPixelClusterShapeCache
Thanks @Dr15Jones. |
The original LazyGetter implementation was not thread-safe and the
facility was never used in production. Removing the code avoids
accidently trying to switch on that facility.
The SiPixelClusterShapeCacheProducer was also switch from a stream
producer to a global producer.