Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hcal det id protect again invalid IDs in digitizer #12066

Merged
merged 2 commits into from Oct 23, 2015

Conversation

davidlange6
Copy link
Contributor

this avoids recently seen crashes in fastsim pileup tests where an invalid hcal det id got into the pileup sample. The real fix is to address that, but meanwhile, as it is a rare event, this PR should avoid the issue..

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @davidlange6 (David Lange) for CMSSW_8_0_X.

Hcal det id protect again invalid IDs in digitizer

It involves the following packages:

SimCalorimetry/HcalSimProducers

@cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@davidlange6
Copy link
Contributor Author

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/9152/console

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

davidlange6 added a commit that referenced this pull request Oct 23, 2015
Hcal det id protect again invalid IDs in digitizer
@davidlange6 davidlange6 merged commit d4ddd7f into cms-sw:CMSSW_8_0_X Oct 23, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants