Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alca beam spot harvester fix v2 cmssw 7 5 x #12073

Merged

Conversation

gennai
Copy link
Contributor

@gennai gennai commented Oct 23, 2015

Fix needed to prevent too small sigmaZ beam spot results to be considered in the harvester

… a too small sigmaZ values. Default cut is at 1 cm
… a too small sigmaZ values. Default cut is at 1 cm
… a too small sigmaZ values. Default cut is at 1 cm
… a too small sigmaZ values. Default cut is at 1 cm
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @gennai (simone gennai) for CMSSW_7_5_X.

Alca beam spot harvester fix v2 cmssw 7 5 x

It involves the following packages:

Calibration/TkAlCaRecoProducers

@cmsbuild, @mmusich, @diguida, @franzoni, @cerminar can you please review it and eventually sign? Thanks.
@threus this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@diguida
Copy link
Contributor

diguida commented Oct 23, 2015

please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/9162/console

@cmsbuild
Copy link
Contributor

@mmusich
Copy link
Contributor

mmusich commented Oct 23, 2015

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_7_6_X is complete. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_7_6_X is complete. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request Oct 27, 2015
…W_7_5_X

Alca beam spot harvester fix v2 cmssw 7 5 x
@cmsbuild cmsbuild merged commit 9785dd0 into cms-sw:CMSSW_7_5_X Oct 27, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants