FWCore/Utilities: remove intrusive macros breaking libstdc++ #12092
Conversation
|
A new Pull Request was created by @davidlt for CMSSW_8_0_X. FWCore/Utilities: remove intrusive macros breaking libstdc++ It involves the following packages: FWCore/Utilities @cmsbuild, @smuzaffar, @Dr15Jones can you please review it and eventually sign? Thanks. |
| @@ -4,10 +4,20 @@ | |||
| #include <algorithm> | |||
| #include <array> | |||
|
|
|||
| // Function for testing RunningAverage | |||
| namespace test { | |||
| namespace RunningAverage { | |||
There was a problem hiding this comment.
CMS naming convention is namespaces start with a lower case letter.
We cannot redefine 'private' and 'protected' keywords via macros to e.g. 'public'. This is extremely intrusive and breaks encapsulation. This does not work anymore with new libstdc++ libraries, because foward delcaration of struct is implicitly private and then implementation is under explicit private clause. Redefining 'private' only change one of them thus creating compile-time errors in sstream. Details in PR65899 (GCC BZ). It's WONTFIX. Such cleanups are required for GCC 5 and above. Signed-off-by: David Abdurachmanov <David.Abdurachmanov@cern.ch>
davidlt
force-pushed
the
fix-priv-macros-FWCore-Utilities
branch
from
943be85
to
7a0a8ef
Compare
|
+1 |
|
The tests are being triggered in jenkins. |
cmsbuild
added
core-approved
fully-signed
tests-pending
and removed
core-pending
pending-signatures
tests-approved
labels
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar |
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar |
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar |
|
+1 |
FWCore/Utilities: remove intrusive macros breaking libstdc++
We cannot redefine 'private' and 'protected' keywords via macros to e.g.
'public'. This is extremely intrusive and breaks encapsulation.
This does not work anymore with new libstdc++ libraries, because foward
delcaration of struct is implicitly private and then implementation is
under explicit private clause. Redefining 'private' only change one of
them thus creating compile-time errors in sstream.
Details in PR65899 (GCC BZ). It's WONTFIX.
Such cleanups are required for GCC 5 and above.
Signed-off-by: David Abdurachmanov David.Abdurachmanov@cern.ch