Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minimal Change: reading tags from CondDBv2 #12094

Merged
merged 1 commit into from Oct 30, 2015

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Oct 26, 2015

That's the minimal change. In the end all tags need to go in GT.

@mmusich
Copy link
Contributor Author

mmusich commented Oct 26, 2015

@slava77 this passes at least the runTheMatrix.py -l limited tests. In the end we need the Tau people to identifiy which tags out of the 133 they have in DB they need in GT. @diguida @andrewj314

@mmusich
Copy link
Contributor Author

mmusich commented Oct 26, 2015

please test

@cmsbuild cmsbuild added this to the Next CMSSW_8_0_X milestone Oct 26, 2015
@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/9192/console

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mmusich (Marco Musich) for CMSSW_8_0_X.

Minimal Change: reading tags from CondDBv2

It involves the following packages:

RecoTauTag/Configuration

@cmsbuild, @cvuosalo, @slava77 can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@slava77
Copy link
Contributor

slava77 commented Oct 26, 2015

@mmusich This will work for 76X/later where everything is v2, right?
I suppose, we will not update anything in 74X.
Please confirm.

@mmusich
Copy link
Contributor Author

mmusich commented Oct 26, 2015

@slava77 should work everywhere past 74X included.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@cvuosalo
Copy link
Contributor

+1

For #12094 1109169

Small change for reading tau tags from CondDBv2.

Jenkins tests against baseline CMSSW_8_0_X_2015-10-25-2300 show no significant differences.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

+1
thanks! lets get this into 76x..

cmsbuild added a commit that referenced this pull request Oct 30, 2015
Minimal Change: reading tags from CondDBv2
@cmsbuild cmsbuild merged commit 9f3fbc4 into cms-sw:CMSSW_8_0_X Oct 30, 2015
@mmusich
Copy link
Contributor Author

mmusich commented Nov 2, 2015

@davidlange6 sorry for the late reply (I was offline in the last 4 days). Shall I provide the PR for 76X or being 760 already built I am too late?

@davidlange6
Copy link
Contributor

@mmusich - no problem - a 76x PR will still be useful. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants