Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding label HLT for PFCalibrationRcd #12109

Merged
merged 1 commit into from Oct 27, 2015

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Oct 27, 2015

Summary of Changes in the GT

RunI data

RunII data

Needed for #12100 to pass addOn tests

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mmusich (Marco Musich) for CMSSW_8_0_X.

Adding label HLT for PFCalibrationRcd

It involves the following packages:

Configuration/AlCa

@cmsbuild, @mmusich, @diguida, @franzoni, @cerminar can you please review it and eventually sign? Thanks.
@ghellwig, @Martin-Grunewald this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@mmusich
Copy link
Contributor Author

mmusich commented Oct 27, 2015

please test

@cmsbuild
Copy link
Contributor

@diguida
Copy link
Contributor

diguida commented Oct 27, 2015

+1
provided Jenkins agrees.
The new label is only used by addOn tests.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@cmsbuild
Copy link
Contributor

The jenkins tests job failed, please try again.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/9216/console

@mmusich
Copy link
Contributor Author

mmusich commented Oct 27, 2015

please test

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@cmsbuild
Copy link
Contributor

@mmusich
Copy link
Contributor Author

mmusich commented Oct 27, 2015

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

@mmusich - I take it that the payloads with the new labels are the same as those used by the reco?

@mmusich
Copy link
Contributor Author

mmusich commented Oct 27, 2015

no they aren't. They are explicitly different upon request of TSG (that's the purpose of having the HLT label). @fwyzard

@fwyzard
Copy link
Contributor

fwyzard commented Oct 27, 2015

Indeed, the tag with the "HLT" label should have the calibrations for the HLT (like for the JECs etc.)

.A

@davidlange6
Copy link
Contributor

should one not then see this effect in the comparisons?

@mmusich
Copy link
Contributor Author

mmusich commented Oct 27, 2015

@davidlange6 only after #12100 is merged IIUC

@fwyzard
Copy link
Contributor

fwyzard commented Oct 27, 2015

Correct, #12100 makes use of the new labels.

@davidlange6
Copy link
Contributor

+1
thanks

cmsbuild added a commit that referenced this pull request Oct 27, 2015
Adding label HLT for PFCalibrationRcd
@cmsbuild cmsbuild merged commit 370f837 into cms-sw:CMSSW_8_0_X Oct 27, 2015
@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants