Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Declare constant statics const #1214

Merged
merged 2 commits into from Oct 29, 2013

Conversation

wmtan
Copy link
Contributor

@wmtan wmtan commented Oct 29, 2013

Declare statics in the framework that are never modified as "const". These were detected by the static analyzer.
This pull request is just for those found and fixed today. There will be more.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @wmtan for CMSSW_7_0_X.

Declare constant statics const

It involves the following packages:

FWCore/Utilities
FWCore/RootAutoLibraryLoader
FWCore/PluginManager
FWCore/Framework

@smuzaffar, @Dr15Jones, @ktf, @nclopezo can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@ktf you are the release manager for this.

@Dr15Jones
Copy link
Contributor

+1
As long as these pass the usual pre-tests

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IBs unless changes or unless it breaks tests. @ktf can you please take care of it?

@@ -5,8 +5,8 @@

namespace edm {
inline
std::string getPassID () {
static std::string passID;
std::string const getPassID () {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There was no reason to declare the return type 'const' since it was already a copy

@cmsbuild
Copy link
Contributor

Pull request #1214 was updated. @smuzaffar, @Dr15Jones, @ktf, @nclopezo can you please check and sign again.

@nclopezo
Copy link
Contributor

+1
the errors in the unit tests are the ones that were already in the IB:

https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/1057/summary.html

ktf added a commit that referenced this pull request Oct 29, 2013
Multithreading fixes -- Declare constant statics const
@ktf ktf merged commit a4dc017 into cms-sw:CMSSW_7_0_X Oct 29, 2013
@wmtan wmtan deleted the DeclareConstantStaticsConst branch October 29, 2013 16:13
NJManganelli pushed a commit to NJManganelli/cmssw that referenced this pull request Mar 7, 2024
More updates to Tau NN [14_0_0_pre3]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants