New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Declare constant statics const #1214
Conversation
A new Pull Request was created by @wmtan for CMSSW_7_0_X. Declare constant statics const It involves the following packages: FWCore/Utilities @smuzaffar, @Dr15Jones, @ktf, @nclopezo can you please review it and eventually sign? Thanks. |
+1 |
This pull request is fully signed and it will be integrated in one of the next IBs unless changes or unless it breaks tests. @ktf can you please take care of it? |
@@ -5,8 +5,8 @@ | |||
|
|||
namespace edm { | |||
inline | |||
std::string getPassID () { | |||
static std::string passID; | |||
std::string const getPassID () { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was no reason to declare the return type 'const' since it was already a copy
Pull request #1214 was updated. @smuzaffar, @Dr15Jones, @ktf, @nclopezo can you please check and sign again. |
+1 https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/1057/summary.html |
Multithreading fixes -- Declare constant statics const
More updates to Tau NN [14_0_0_pre3]
Declare statics in the framework that are never modified as "const". These were detected by the static analyzer.
This pull request is just for those found and fixed today. There will be more.