Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Phase1 pixel and Phase2 (2023) eras #12169

Closed

Conversation

mark-grimes
Copy link

Add a Run2_2017 era that includes the Phase 1 pixel detector; and a Phase2Dev era for every Phase2 component that currently works in 76X. I'm not entirely convinced by the name Phase2Dev, if anyone wants it changed please comment here.

Put in on 7_6_X, not sure if it should be 8_0_X only?

Currently no changes added to either scenario, I thought integration would be easier if that was done in separate pull requests. Note that this includes #12124 otherwise there would probably be merge conflicts (EDIT - now no longer true; decoupled from #12124).

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mark-grimes (Mark Grimes) for CMSSW_7_6_X.

Add Phase1 pixel and Phase2 (2023) eras

It involves the following packages:

Configuration/StandardSequences

@cmsbuild, @franzoni, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @makortel, @GiacomoSguazzoni, @rovere, @VinInn, @Martin-Grunewald, @cerati, @dgulhan this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' or '@cmsbuild, please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@davidlange6
Copy link
Contributor

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/9329/console

@cmsbuild
Copy link
Contributor

-1

Tested at: b8c1d4d
I found errors in the following addon tests:

cmsDriver.py RelVal -s L1REPACK:GCTGT --data --scenario=pp -n 10 --conditions auto:run2_hlt_50nsGRun --relval 9000,50 --datatier "RAW" --eventcontent RAW --customise=HLTrigger/Configuration/CustomConfigs.L1T --era Run2_50ns --magField 38T_PostLS1 --fileout file:RelVal_Raw_50nsGRun_DATA.root --filein /store/data/Run2012A/MuEG/RAW/v1/000/191/718/14932935-E289-E111-830C-5404A6388697.root : FAILED - time: date Thu Oct 29 18:07:44 2015-date Thu Oct 29 18:04:02 2015 s - exit: 16640

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12169/9329/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
fab7c87
0470aa9
20fed42
ccadd32
3b78b2d
d8345fe
2510690
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12169/9329/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12169/9329/git-merge-result

@cmsbuild
Copy link
Contributor

@davidlange6
Copy link
Contributor

@mark-grimes @Martin-Grunewald - does this error make sense to you?

@mark-grimes
Copy link
Author

Checking through, and pretty sure it's because of #12124 (taking stage1L1Trigger out of 50ns). Something is in the stage1L1Trigger "sub-era" that should maybe be in run2_common.

@mark-grimes
Copy link
Author

Decoupled from #12124, I'll worry about merge conflicts in that later. Tested the failing test and it now works.

@mark-grimes
Copy link
Author

please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/9377/console

@cmsbuild
Copy link
Contributor

Pull request #12169 was updated. @cmsbuild, @franzoni, @davidlange6 can you please check and sign again.

@cmsbuild
Copy link
Contributor

-1
Tested at: 1ac941b
I found an error when building:

>> Compiling  /afs/cern.ch/work/c/cmsbuild/jenkins-workarea/lxplus6-24/workspace/ib-any-integration/CMSSW_7_6_X_2015-10-29-2300/src/DQM/L1TMonitor/src/L1TRPCTPG.cc 
>> Compiling  /afs/cern.ch/work/c/cmsbuild/jenkins-workarea/lxplus6-24/workspace/ib-any-integration/CMSSW_7_6_X_2015-10-29-2300/src/DQM/L1TMonitor/src/L1TRate.cc 
>> Compiling  /afs/cern.ch/work/c/cmsbuild/jenkins-workarea/lxplus6-24/workspace/ib-any-integration/CMSSW_7_6_X_2015-10-29-2300/src/DQM/L1TMonitor/src/L1TSync.cc 
>> Compiling  /afs/cern.ch/work/c/cmsbuild/jenkins-workarea/lxplus6-24/workspace/ib-any-integration/CMSSW_7_6_X_2015-10-29-2300/src/DQM/L1TMonitor/src/L1TdeCSCTF.cc 
{standard input}: Assembler messages:
{standard input}: Fatal error: can't close tmp/slc6_amd64_gcc493/src/DQM/L1TMonitor/src/DQML1TMonitor/L1TRCT.o: Disk quota exceeded
/afs/cern.ch/work/c/cmsbuild/jenkins-workarea/lxplus6-24/workspace/ib-any-integration/CMSSW_7_6_X_2015-10-29-2300/src/DQM/L1TMonitor/src/L1TRCT.cc:287:1: fatal error: opening dependency file tmp/slc6_amd64_gcc493/src/DQM/L1TMonitor/src/DQML1TMonitor/L1TRCT.d: Disk quota exceeded
 }
 ^
compilation terminated.
/afs/cern.ch/work/c/cmsbuild/jenkins-workarea/lxplus6-24/workspace/ib-any-integration/CMSSW_7_6_X_2015-10-29-2300/src/DQM/L1TMonitor/src/L1TMenuHelper.cc:541:1: fatal error: opening dependency file tmp/slc6_amd64_gcc493/src/DQM/L1TMonitor/src/DQML1TMonitor/L1TMenuHelper.d: Disk quota exceeded


you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12169/9377/summary.html

@mark-grimes
Copy link
Author

Oh dear. @smuzaffar whom should I inform of errors with the build machines?

@mark-grimes
Copy link
Author

Closing to put in on 8_0_X only, see #12254.

@mark-grimes mark-grimes closed this Nov 4, 2015
@mark-grimes mark-grimes deleted the addPhase1AndPhase2Eras branch November 5, 2015 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants