Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove evtgen plugin in Pythia8Interface 53X #12189

Merged
1 commit merged into from Nov 5, 2015

Conversation

mkirsano
Copy link
Contributor

No description provided.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mkirsano (Mikhail Kirsanov) for CMSSW_5_3_X.

remove evtgen plugin in Pythia8Interface 53X

It involves the following packages:

GeneratorInterface/Pythia8Interface

@vciulli, @covarell, @thuer, @cmsbuild, @bendavid, @govoni can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' or '@cmsbuild, please test' in the first line of a comment.
@smuzaffar you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@bendavid
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/9348/console

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_5_3_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

@cmsbuild
Copy link
Contributor

-1
Tested at: f9087e1
I found an error when building:

>> Compiling  /afs/cern.ch/work/c/cmsbuild/jenkins-workarea/lxplus6-05/workspace/ib-any-integration/CMSSW_5_3_X_2015-10-29-1100/src/GeneratorInterface/Pythia8Interface/src/Py8GunBase.cc 
>> Compiling edm plugin /afs/cern.ch/work/c/cmsbuild/jenkins-workarea/lxplus6-05/workspace/ib-any-integration/CMSSW_5_3_X_2015-10-29-1100/src/GeneratorInterface/Pythia8Interface/plugins/Pythia8Hadronizer.cc 
>> Compiling edm plugin /afs/cern.ch/work/c/cmsbuild/jenkins-workarea/lxplus6-05/workspace/ib-any-integration/CMSSW_5_3_X_2015-10-29-1100/src/GeneratorInterface/Pythia8Interface/plugins/Py8toJetInput.cc 
>> Compiling edm plugin /afs/cern.ch/work/c/cmsbuild/jenkins-workarea/lxplus6-05/workspace/ib-any-integration/CMSSW_5_3_X_2015-10-29-1100/src/GeneratorInterface/Pythia8Interface/plugins/EmissionVetoHook1.cc 
/afs/cern.ch/work/c/cmsbuild/jenkins-workarea/lxplus6-05/workspace/ib-any-integration/CMSSW_5_3_X_2015-10-29-1100/src/GeneratorInterface/Pythia8Interface/src/Py8GunBase.cc: In member function 'virtual bool gen::Py8GunBase::residualDecay()':
/afs/cern.ch/work/c/cmsbuild/jenkins-workarea/lxplus6-05/workspace/ib-any-integration/CMSSW_5_3_X_2015-10-29-1100/src/GeneratorInterface/Pythia8Interface/src/Py8GunBase.cc:110:89: error: no matching function for call to 'HepMC::Pythia8ToHepMC::fill_next_event(std::auto_ptrPythia8::Pythia::element_type&, std::auto_ptrHepMC::GenEvent::element_type_, int, bool, HepMC::GenParticle_&)'
/afs/cern.ch/work/c/cmsbuild/jenkins-workarea/lxplus6-05/workspace/ib-any-integration/CMSSW_5_3_X_2015-10-29-1100/src/GeneratorInterface/Pythia8Interface/src/Py8GunBase.cc:110:89: note: candidates are:
In file included from /afs/cern.ch/work/c/cmsbuild/jenkins-workarea/lxplus6-05/workspace/ib-any-integration/CMSSW_5_3_X_2015-10-29-1100/src/GeneratorInterface/Pythia8Interface/interface/Py8InterfaceBase.h:12:0,
                 from /afs/cern.ch/work/c/cmsbuild/jenkins-workarea/lxplus6-05/workspace/ib-any-integration/CMSSW_5_3_X_2015-10-29-1100/src/GeneratorInterface/Pythia8Interface/interface/Py8GunBase.h:21,
                 from /afs/cern.ch/work/c/cmsbuild/jenkins-workarea/lxplus6-05/workspace/ib-any-integration/CMSSW_5_3_X_2015-10-29-1100/src/GeneratorInterface/Pythia8Interface/src/Py8GunBase.cc:1:
/afs/cern.ch/cms/sw/ReleaseCandidates/vol0/slc6_amd64_gcc472/external/pythia8/205/include/Pythia8Plugins/HepMC2.h:38:8: note: bool HepMC::Pythia8ToHepMC::fill_next_event(Pythia8::Pythia&, HepMC::GenEvent*, int)


you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12189/9348/summary.html

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_5_3_X IBs (but tests are reportedly failing). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

@mkirsano
Copy link
Contributor Author

To be built against cmsdist #1937

@mkirsano
Copy link
Contributor Author

mkirsano commented Nov 5, 2015

There was this email:

There was an issue with git-cms-merge-topic you can see the log here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12189/5/git-merge-result

Is there a problem?
By the way, I have no access to the logs like above.

@ghost
Copy link

ghost commented Nov 5, 2015

@mkirsano I know, I'm using this PR to test also a new feature. The error was unrelated with the content of your PR.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 5, 2015

-1

Tested at: f9087e1
I found errors in the following addon tests:

cmsRun /afs/cern.ch/cms/sw/ReleaseCandidates/vol1/slc6_amd64_gcc472/cms/cmssw-patch/CMSSW_5_3_X_2015-11-05-1100/src/PhysicsTools/PatAlgos/test/IntegrationTest_cfg.py : FAILED - time: date Thu Nov 5 15:24:29 2015-date Thu Nov 5 15:23:07 2015 s - exit: 23552

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/cmsdist-test-pr/PR-12189/9/summary.html

@ghost
Copy link

ghost commented Nov 5, 2015

+1
I think we can ignore the above tests for this release.
The other tests where fine. The correct URL is this one:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12189/9/summary.html

@davidlange6
Copy link
Contributor

@Degano - could you go ahead and do the consistent merge?

On Nov 5, 2015, at 4:07 PM, Alessandro Degano notifications@github.com wrote:

+1
I think we can ignore the above tests for this release.
The other tests where fine. The correct URL is this one:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12189/9/summary.html


Reply to this email directly or view it on GitHub.

ghost pushed a commit that referenced this pull request Nov 5, 2015
remove evtgen plugin in Pythia8Interface 53X
@ghost ghost merged commit 14dd186 into cms-sw:CMSSW_5_3_X Nov 5, 2015
@ghost
Copy link

ghost commented Nov 5, 2015

@davidlange6 Done here and here: cms-sw/cmsdist#1937

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants