Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Static beam 80x #12211

Merged
merged 2 commits into from Oct 31, 2015
Merged

Static beam 80x #12211

merged 2 commits into from Oct 31, 2015

Conversation

deguio
Copy link
Contributor

@deguio deguio commented Oct 30, 2015

No description provided.

Dmitrijus Bugelskis added 2 commits October 20, 2015 16:03
Fix formatFitTime() not to require a static variable in DQM/BeamMonitor.
5a2132e 
There was no point to have it static anyway.
Fix statics in DQM/BeamMonitor.
00b6259 
Make them members in Vx3DHLTAnalyzer.
Please test before accepting.
@cmsbuild cmsbuild added this to the Next CMSSW_8_0_X milestone Oct 30, 2015
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @deguio (Federico De Guio) for CMSSW_8_0_X.

Static beam 80x

It involves the following packages:

DQM/BeamMonitor

@cmsbuild, @danduggan, @vanbesien, @deguio can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' or '@cmsbuild, please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@deguio
Copy link
Contributor Author

deguio commented Oct 30, 2015

please test

@deguio
Copy link
Contributor Author

deguio commented Oct 30, 2015

+1

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/9392/console
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/9394/console

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@cmsbuild
Copy link
Contributor

+1
Tested at: 00b6259
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12211/9394/summary.html

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12211/9394/summary.html

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request Oct 31, 2015
@cmsbuild
Merge pull request #12211 from dmitrijus/static_beam_try2_75x
fda41d6 
Static beam 80x
@cmsbuild cmsbuild merged commit fda41d6 into cms-sw:CMSSW_8_0_X Oct 31, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
comparison-available dqm-approved fully-signed tests-approved
Projects
None yet
Milestone
CMSSW_8_0_X
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@deguio @cmsbuild @davidlange6