Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up errors reported by static analyzer #1222

Merged
merged 2 commits into from Oct 30, 2013
Merged

Clean up errors reported by static analyzer #1222

merged 2 commits into from Oct 30, 2013

Conversation

ianna
Copy link
Contributor

@ianna ianna commented Oct 29, 2013

  • Clean up errors reported by static analyzer
  • Fix configurations to run on auto conditions

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @ianna for CMSSW_7_0_X.

Clean up errors reported by static analyzer

It involves the following packages:

Geometry/DTGeometry

@smuzaffar, @civanch, @Dr15Jones, @ianna, @mdhildreth, @nclopezo, @ktf can you please review it and eventually sign? Thanks.
@ghellwig this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@ktf you are the release manager for this.

@cmsbuild
Copy link
Contributor

+1
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/1084/summary.html

@ktf
Copy link
Contributor

ktf commented Oct 30, 2013

@ianna, any reason why you did not sign it for geometry?

@ianna
Copy link
Contributor Author

ianna commented Oct 30, 2013

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IBs unless changes or unless it breaks tests. @ktf can you please take care of it?

ktf added a commit that referenced this pull request Oct 30, 2013
@ktf
Merge pull request #1222 from ianna/geometry-dtgeometry-statics-cleanup
016996d 
Misc Geometry fixes -- statics in Geometry/DTGeometry, use auto conditions
@ktf ktf merged commit 016996d into cms-sw:CMSSW_7_0_X Oct 30, 2013
ktf
ktf reviewed Oct 30, 2013
View reviewed changes
Geometry/DTGeometry/test/testDTGeometryFromLocalDB_cfg.py
@@ -4,7 +4,9 @@
process.load("Configuration.StandardSequences.GeometryDB_cff")
process.load("CondCore.DBCommon.CondDBSetup_cfi")
process.load('Configuration.StandardSequences.FrontierConditions_GlobalTag_cff')
process.GlobalTag.globaltag = 'MC_31X_V8::All'
from Configuration.AlCa.autoCond import autoCond
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general you should use two different pull requests for logically orthogonal changes.

@ianna ianna deleted the geometry-dtgeometry-statics-cleanup branch October 26, 2015 16:31
jmitrevs pushed a commit to jmitrevs/cmssw that referenced this pull request Mar 12, 2024
@aloeliger
Merge pull request cms-sw#1222 from aloeliger/GMT_GT_Fix
43ef297 
GMT GT Fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
fully-signed geometry-approved tests-pending
Projects
None yet
Milestone
CMSSW_7_0_0_pre8
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ianna @cmsbuild @ktf