Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added bool to prevent multiple initialization of the Sherpa Object #12244

Conversation

thuer
Copy link
Contributor

@thuer thuer commented Nov 3, 2015

Backport of Sherpa multiple initialization fix

@bendavid
Copy link
Contributor

bendavid commented Nov 3, 2015

+1

@cmsbuild cmsbuild added this to the Next CMSSW_7_1_X milestone Nov 3, 2015
@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 3, 2015

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/9431/console

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 3, 2015

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 3, 2015

A new Pull Request was created by @thuer (Sebastian Thüer) for CMSSW_7_1_X.

Added bool to prevent multiple initialization of the Sherpa Object

It involves the following packages:

GeneratorInterface/SherpaInterface

@cmsbuild can you please review it and eventually sign? Thanks.
@mkirsano this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' or '@cmsbuild, please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 3, 2015

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 3, 2015

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 3, 2015

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 3, 2015

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request Nov 3, 2015
…nitialization

Added bool to prevent multiple initialization of the Sherpa Object
@cmsbuild cmsbuild merged commit e354540 into cms-sw:CMSSW_7_1_X Nov 3, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants