Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Dstar filter for enriched MC production request #12249

Merged
merged 1 commit into from Dec 3, 2015

Conversation

vmariani
Copy link
Contributor

@vmariani vmariani commented Nov 3, 2015

No description provided.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 3, 2015

A new Pull Request was created by @vmariani for CMSSW_7_6_X.

Adding Dstar filter for enriched MC production request

It involves the following packages:

GeneratorInterface/ExternalDecays
GeneratorInterface/GenFilters

@vciulli, @covarell, @thuer, @cmsbuild, @bendavid, @govoni can you please review it and eventually sign? Thanks.
@inugent, @mkirsano this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' or '@cmsbuild, please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@govoni
Copy link
Contributor

govoni commented Nov 11, 2015

+1

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/9656/console

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@covarell
Copy link
Contributor

This should also be forward-ported to 8_0_X and back-ported to 7_1_X if it needs to be used in official production

@cmsbuild
Copy link
Contributor

-1
Tested at: bd61844
When I ran the RelVals I found an error in the following worklfows:
1003.0 step1

DAS Error

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12249/9656/summary.html

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (but tests are reportedly failing). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@rovere
Copy link
Contributor

rovere commented Nov 13, 2015

@cmsbuild
DAS Error, please test again.

@rovere
Copy link
Contributor

rovere commented Nov 16, 2015

Can someone take care of this PR and re-trigger the tests, please?

@smuzaffar
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/9729/console

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@rovere
Copy link
Contributor

rovere commented Nov 23, 2015

Any reason to prevent the integration of this PR into the release? It is mandatory to submit MC for the D*/tracking efficiency studies for 2015.
Tracking POG fully support this PR.

@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request Dec 3, 2015
Adding Dstar filter for enriched MC production request
@cmsbuild cmsbuild merged commit 11b7bb8 into cms-sw:CMSSW_7_6_X Dec 3, 2015
@rovere
Copy link
Contributor

rovere commented Dec 3, 2015

Thanks @davidlange6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants