Fix bug in caching of surface deformations. #12282
Conversation
This bug has an effect if the DetUnits of a large tracker structure are not listed at all. The net effect of this fix is that omitting them leaves them and the associated surface deformations unchanged.
|
A new Pull Request was created by @ghellwig (Gregor Mittag) for CMSSW_7_5_X. Fix bug in caching of surface deformations. It involves the following packages: Alignment/CommonAlignment @cmsbuild, @mmusich, @diguida, @franzoni, @cerminar can you please review it and eventually sign? Thanks. |
|
please test |
|
The tests are being triggered in jenkins. |
|
+1 |
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_7_6_X is complete. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar |
cmsbuild
added
alca-approved
fully-signed
and removed
alca-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_7_6_X is complete. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar |
|
+1 |
…ng_for_non-alignables_75X Fix bug in caching of surface deformations.
ghellwig
deleted the
fix_surface-deformation-caching_for_non-alignables_75X
branch
This bug has an effect if the DetUnits of a large tracker structure
that are not listed at all. The net effect of this fix is that omitting
them leaves them and the associated surface deformations unchanged.
This serious bug is discussed in https://indico.cern.ch/event/442138/session/0/contribution/21/attachments/1182456/1712522/talk.pdf
Backport of #12280.