fix bug in the jetIDcleaning module #12346

safarzad · 2015-11-10T14:11:06Z

fix bug in the jetIDcleaning module

cmsbuild · 2015-11-10T14:11:15Z

A new Pull Request was created by @safarzad for CMSSW_8_0_X.

fix bug in the jetIDcleaning module

It involves the following packages:

HLTrigger/JetMET

@Martin-Grunewald, @perrotta, @cmsbuild, @fwyzard can you please review it and eventually sign? Thanks.
@Martin-Grunewald this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' or '@cmsbuild, please test' 'please test with cms-sw/cmsdist#PR' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

cmsbuild · 2015-11-10T14:16:19Z

Pull request #12346 was updated. @Martin-Grunewald, @perrotta, @cmsbuild, @fwyzard can you please check and sign again.

safarzad · 2015-11-10T14:16:45Z

I made this PR from CMSSW800_pre1 release hope works

Martin-Grunewald · 2015-11-10T14:26:59Z

You still did not remove "usePt" from the .h header file...

cmsbuild · 2015-11-10T14:31:31Z

Pull request #12346 was updated. @Martin-Grunewald, @perrotta, @cmsbuild, @fwyzard can you please check and sign again.

Martin-Grunewald · 2015-11-10T14:34:37Z

please test

cmsbuild · 2015-11-10T14:36:21Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/9605/console

cmsbuild · 2015-11-10T17:11:49Z

+1
Tested at: bcb251d
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12346/9605/summary.html

cmsbuild · 2015-11-10T20:51:27Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12346/9605/summary.html

kirschen · 2015-11-12T12:51:57Z

HLTrigger/JetMET/src/HLTMETCleanerUsingJetID.cc

-        reco::CaloMET cleanmet = met->front();
-        cleanmet.setP4(cleanmet.p4() + p4_diff);
+        reco::CaloMET cleanmet ;
+        cleanmet.setP4(p4_diff);


Hi Batool,

thanks for putting up the PR!
Two questions/suggestions came to my mind after taking a look at the proposed changes:

what about renaming p4_diff to e.g. cleanmetp4 (L96/99)? With the proposed code changes, it has a different meaning than before. It would be good to change the name, then.

Does the change from reco::CaloMET cleanmet = met->front(); to initializing a fresh object reco::CaloMET cleanmet ; before setting the p4 loose any information that might be useful to have? The way you propose is definitely cleaner, I am just wondering...

Cheers,
Henning

Can the proponent please address these issues?

Hi,

I do not see any issue here, it is about renaming a collection that I do not think make any differences at the end in physiscs.

The second part is not clear for me which information will be missing, but in general the idea here is to have a new collection that does not inherent from original caloMET collection

Hi,

Is there anything left that I must to do to merge this PR?

@kirschen
please comment!

Well, my comments are no showstoppers, but I thought we could follow up quickly. To clarify a bit what I was aiming at:

Renaming:
Sure, it does not change physics, but why should one retain misleading/wrong variable names?

Usability of cleanmet:
If I understand correctly, the "cleanmet" here will contain only the p4-vector information, but none of the CaloMET-specifics that are usually added in https://github.com/cms-sw/cmssw/blob/6b16de370881dd8ef339d34811b3d1e176c02b80/RecoMET/METAlgorithms/src/CaloSpecificAlgo.cc called from https://github.com/cms-sw/cmssw/blob/6b16de370881dd8ef339d34811b3d1e176c02b80/RecoMET/METProducers/src/CaloMETProducer.cc
So the output here uses the CaloMET data format, but only contains a small fraction of the information that is usually associated with this object. However, I guess putting the minimal information here is still better than the old behavior before the PR (retaining the old detail information before JetId-cleaning, which is incorrect when removing jets).

Martin,

If I make a small modification from p4_diff to p4_Clean do we need to go trough the whole test procedures?

@safarzad
Please address the comments from @kirschen and submit the corrections to the branch of this PR.
[We'll then request jenkins automatic testing in any case, as the PR can not be integrated without.]

Martin-Grunewald · 2015-11-23T09:53:00Z

please test

cmsbuild · 2015-11-23T09:56:10Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/9892/console

cmsbuild · 2015-11-23T11:31:23Z

-1
Tested at: de6bbe6
When I ran the RelVals I found an error in the following worklfows:
1001.0 step3

runTheMatrix-results/1001.0_RunMinBias2011A+RunMinBias2011A+TIER0EXP+ALCAEXP+ALCAHARVD1+ALCAHARVD2+ALCAHARVD3+ALCAHARVD4/step3_RunMinBias2011A+RunMinBias2011A+TIER0EXP+ALCAEXP+ALCAHARVD1+ALCAHARVD2+ALCAHARVD3+ALCAHARVD4.log

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12346/9892/summary.html

safarzad · 2015-11-23T11:39:38Z

To find out what is the error I checked this (i think it is that you are referring right?) but there is no error just processing the event. Can you clarify?
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12346/9892/runTheMatrix-results/1001.0_RunMinBias2011A+RunMinBias2011A+TIER0EXP+ALCAEXP+ALCAHARVD1+ALCAHARVD2+ALCAHARVD3+ALCAHARVD4/step3_RunMinBias2011A+RunMinBias2011A+TIER0EXP+ALCAEXP+ALCAHARVD1+ALCAHARVD2+ALCAHARVD3+ALCAHARVD4.log

safarzad · 2015-11-23T11:41:54Z

To find out what is the error I checked this (i think it is that you are referring right?) but there is no error just processing the event. Can you clarify?
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12346/9892/runTheMatrix-results/1001.0_RunMinBias2011A+RunMinBias2011A+TIER0EXP+ALCAEXP+ALCAHARVD1+ALCAHARVD2+ALCAHARVD3+ALCAHARVD4/step3_RunMinBias2011A+RunMinBias2011A+TIER0EXP+ALCAEXP+ALCAHARVD1+ALCAHARVD2+ALCAHARVD3+ALCAHARVD4.log

From: cmsbuild [notifications@github.com]
Sent: 23 November 2015 12:31
To: cms-sw/cmssw
Cc: Batool Safarzadeh Samani
Subject: Re: [cmssw] fix bug in the jetIDcleaning module (#12346)

-1
Tested at: de6bbe6de6bbe6
When I ran the RelVals I found an error in the following worklfows:
1001.0 step3

runTheMatrix-results/1001.0_RunMinBias2011A+RunMinBias2011A+TIER0EXP+ALCAEXP+ALCAHARVD1+ALCAHARVD2+ALCAHARVD3+ALCAHARVD4/step3_RunMinBias2011A+RunMinBias2011A+TIER0EXP+ALCAEXP+ALCAHARVD1+ALCAHARVD2+ALCAHARVD3+ALCAHARVD4.log

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12346/9892/summary.html

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/12346#issuecomment-158910144.

Martin-Grunewald · 2015-11-23T11:53:05Z

The log file seems cut off (the usual end of run messages are missing).

Martin-Grunewald · 2015-11-23T11:53:14Z

please test

cmsbuild · 2015-11-23T11:56:18Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/9896/console
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/9897/console

cmsbuild · 2015-11-23T14:25:35Z

+1
Tested at: de6bbe6
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12346/9897/summary.html

Martin-Grunewald · 2015-11-23T14:27:44Z

+1

cmsbuild · 2015-11-23T14:31:29Z

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

cmsbuild · 2015-11-23T15:32:20Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12346/9897/summary.html

davidlange6 · 2015-11-25T03:25:59Z

+1

fix bug in the jetIDcleaning module

fix bug in the jetIDcleaning module

3c6285e

cmsbuild added this to the Next CMSSW_8_0_X milestone Nov 10, 2015

cmsbuild added hlt-pending pending-signatures tests-pending orp-pending comparison-pending labels Nov 10, 2015

customize PR12346

469f441

remove usePt option

bcb251d

cmsbuild added tests-started and removed tests-pending labels Nov 10, 2015

cmsbuild added tests-approved and removed tests-started labels Nov 10, 2015

cmsbuild added comparison-available and removed comparison-pending labels Nov 10, 2015

kirschen reviewed Nov 12, 2015
View reviewed changes

fixing the issues with cleanPFMET

de6bbe6

cmsbuild removed comparison-available tests-approved labels Nov 23, 2015

cmsbuild added the tests-started label Nov 23, 2015

cmsbuild added tests-rejected and removed tests-started labels Nov 23, 2015

cmsbuild added tests-pending tests-started and removed tests-rejected tests-pending labels Nov 23, 2015

cmsbuild added tests-approved and removed tests-started labels Nov 23, 2015

cmsbuild added hlt-approved fully-signed and removed hlt-pending pending-signatures labels Nov 23, 2015

cmsbuild added comparison-available and removed comparison-pending labels Nov 23, 2015

cmsbuild added orp-approved and removed orp-pending labels Nov 25, 2015

cmsbuild added a commit that referenced this pull request Nov 25, 2015

Merge pull request #12346 from safarzad/JetIDNoise

6833c72

fix bug in the jetIDcleaning module

cmsbuild merged commit 6833c72 into cms-sw:CMSSW_8_0_X Nov 25, 2015

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix bug in the jetIDcleaning module #12346

fix bug in the jetIDcleaning module #12346

safarzad commented Nov 10, 2015

cmsbuild commented Nov 10, 2015

cmsbuild commented Nov 10, 2015

safarzad commented Nov 10, 2015

Martin-Grunewald commented Nov 10, 2015

cmsbuild commented Nov 10, 2015

Martin-Grunewald commented Nov 10, 2015

cmsbuild commented Nov 10, 2015

cmsbuild commented Nov 10, 2015

cmsbuild commented Nov 10, 2015

kirschen Nov 12, 2015

Martin-Grunewald Nov 19, 2015

safarzad Nov 19, 2015

safarzad Nov 23, 2015

Martin-Grunewald Nov 23, 2015

kirschen Nov 23, 2015

safarzad Nov 23, 2015

Martin-Grunewald Nov 23, 2015

Martin-Grunewald commented Nov 23, 2015

cmsbuild commented Nov 23, 2015

cmsbuild commented Nov 23, 2015

safarzad commented Nov 23, 2015

safarzad commented Nov 23, 2015

Martin-Grunewald commented Nov 23, 2015

Martin-Grunewald commented Nov 23, 2015

cmsbuild commented Nov 23, 2015

cmsbuild commented Nov 23, 2015

Martin-Grunewald commented Nov 23, 2015

cmsbuild commented Nov 23, 2015

cmsbuild commented Nov 23, 2015

davidlange6 commented Nov 25, 2015

fix bug in the jetIDcleaning module #12346

fix bug in the jetIDcleaning module #12346

Conversation

safarzad commented Nov 10, 2015

cmsbuild commented Nov 10, 2015

cmsbuild commented Nov 10, 2015

safarzad commented Nov 10, 2015

Martin-Grunewald commented Nov 10, 2015

cmsbuild commented Nov 10, 2015

Martin-Grunewald commented Nov 10, 2015

cmsbuild commented Nov 10, 2015

cmsbuild commented Nov 10, 2015

cmsbuild commented Nov 10, 2015

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Martin-Grunewald commented Nov 23, 2015

cmsbuild commented Nov 23, 2015

cmsbuild commented Nov 23, 2015

safarzad commented Nov 23, 2015

safarzad commented Nov 23, 2015

Martin-Grunewald commented Nov 23, 2015

Martin-Grunewald commented Nov 23, 2015

cmsbuild commented Nov 23, 2015

cmsbuild commented Nov 23, 2015

Martin-Grunewald commented Nov 23, 2015

cmsbuild commented Nov 23, 2015

cmsbuild commented Nov 23, 2015

davidlange6 commented Nov 25, 2015