fastsim: use fastsim era to define fastsim customs to mixing #12403

lveldere · 2015-11-12T15:02:58Z

Transforming a fullsim configuration for MixingModule to a fastsim configuration, now happens via the fastsim era, rather than a hidden cmsDriver option.

This approach is probably a bit more robust.
If implemented earlier it would have avoided occasions of the past where FastSim did not pick up changes to the fullsim mixing configuration.

Along the way I removed some code duplication in the standard fullsim mixing configuration files.

@mdhildreth
Could you let me know whether this needs discussion?

lveldere · 2015-11-12T15:03:07Z

please test

cmsbuild · 2015-11-12T15:06:12Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/9689/console

cmsbuild · 2015-11-12T15:06:13Z

A new Pull Request was created by @lveldere for CMSSW_8_0_X.

It involves the following packages:

Configuration/Applications
FastSimulation/Configuration
FastSimulation/Tracking
SimCalorimetry/HcalSimProducers
SimGeneral/MixingModule

@ssekmen, @lveldere, @civanch, @mdhildreth, @cmsbuild, @franzoni, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @matt-komm, @Martin-Grunewald, @wmtan this is something you requested to watch as well.
@Degano you are the release manager for this.

Following commands in first line of a comment are recognized

+1|approve[d]|sign[ed]: L1/L2's to approve it
-1|reject[ed]: L1/L2's to reject it
assign <category>[,<category>[,...]]: L1/L2's to request signatures from other categories
unassign <category>[,<category>[,...]]: L1/L2's to remove signatures from other categories
hold: L1/L2's to mark it as on hold
merge: L1/release managers to merge this request
[@cmsbuild,] please test: L1/L2 and selected users to start jenkins tests
[@cmsbuild,] please test with cms-sw/cmsdist#<PR>: L1/L2 and selected users to start jenkins tests using externals from cmsdist

cmsbuild · 2015-11-12T16:34:15Z

-1
Tested at: b1bc1d2
When I ran the RelVals I found an error in the following worklfows:
8.0 step2

runTheMatrix-results/8.0_BeamHalo+BeamHalo+DIGICOS+RECOCOS+ALCABH+HARVESTCOS/step2_BeamHalo+BeamHalo+DIGICOS+RECOCOS+ALCABH+HARVESTCOS.log
----- Begin Fatal Exception 12-Nov-2015 16:37:38 CET-----------------------
An exception of category 'ProductNotFound' occurred while
   [0] Processing run: 1 lumi: 1 event: 1
   [1] Running path 'digi2raw_step'
   [2] Calling event method for module SiPixelDigiToRaw/'siPixelRawData'
Exception Message:
Principal::getByToken: Found zero products matching all criteria
Looking for type: edm::DetSetVector
Looking for module label: simSiPixelDigis
Looking for productInstanceName: 
   Additional Info:
      [a] If you wish to continue processing events after a ProductNotFound exception,
add "SkipEvent = cms.untracked.vstring('ProductNotFound')" to the "options" PSet in the configuration.
----- End Fatal Exception -------------------------------------------------

9.0 step2

runTheMatrix-results/9.0_Higgs200ChargedTaus+Higgs200ChargedTaus+DIGI+RECO+HARVEST/step2_Higgs200ChargedTaus+Higgs200ChargedTaus+DIGI+RECO+HARVEST.log
----- Begin Fatal Exception 12-Nov-2015 16:44:13 CET-----------------------
An exception of category 'ProductNotFound' occurred while
   [0] Processing run: 1 lumi: 1 event: 1
   [1] Running path 'digi2raw_step'
   [2] Calling event method for module SiPixelDigiToRaw/'siPixelRawData'
Exception Message:
Principal::getByToken: Found zero products matching all criteria
Looking for type: edm::DetSetVector
Looking for module label: simSiPixelDigis
Looking for productInstanceName: 
   Additional Info:
      [a] If you wish to continue processing events after a ProductNotFound exception,
add "SkipEvent = cms.untracked.vstring('ProductNotFound')" to the "options" PSet in the configuration.
----- End Fatal Exception -------------------------------------------------

25.0 step2

runTheMatrix-results/25.0_TTbar+TTbar+DIGI+RECOAlCaCalo+HARVEST+ALCATT/step2_TTbar+TTbar+DIGI+RECOAlCaCalo+HARVEST+ALCATT.log
----- Begin Fatal Exception 12-Nov-2015 16:46:47 CET-----------------------
An exception of category 'ProductNotFound' occurred while
   [0] Processing run: 1 lumi: 1 event: 1
   [1] Running path 'digi2raw_step'
   [2] Calling event method for module SiPixelDigiToRaw/'siPixelRawData'
Exception Message:
Principal::getByToken: Found zero products matching all criteria
Looking for type: edm::DetSetVector
Looking for module label: simSiPixelDigis
Looking for productInstanceName: 
   Additional Info:
      [a] If you wish to continue processing events after a ProductNotFound exception,
add "SkipEvent = cms.untracked.vstring('ProductNotFound')" to the "options" PSet in the configuration.
----- End Fatal Exception -------------------------------------------------

1306.0 step2

runTheMatrix-results/1306.0_SingleMuPt1_UP15+SingleMuPt1_UP15+DIGIUP15+RECOUP15+HARVESTUP15/step2_SingleMuPt1_UP15+SingleMuPt1_UP15+DIGIUP15+RECOUP15+HARVESTUP15.log
----- Begin Fatal Exception 12-Nov-2015 16:49:12 CET-----------------------
An exception of category 'ProductNotFound' occurred while
   [0] Processing run: 1 lumi: 1 event: 1
   [1] Running path 'digi2raw_step'
   [2] Calling event method for module SiPixelDigiToRaw/'siPixelRawData'
Exception Message:
Principal::getByToken: Found zero products matching all criteria
Looking for type: edm::DetSetVector
Looking for module label: simSiPixelDigis
Looking for productInstanceName: 
   Additional Info:
      [a] If you wish to continue processing events after a ProductNotFound exception,
add "SkipEvent = cms.untracked.vstring('ProductNotFound')" to the "options" PSet in the configuration.
----- End Fatal Exception -------------------------------------------------

1330.0 step2

runTheMatrix-results/1330.0_ZMM_13+ZMM_13+DIGIUP15+RECOUP15+HARVESTUP15/step2_ZMM_13+ZMM_13+DIGIUP15+RECOUP15+HARVESTUP15.log
----- Begin Fatal Exception 12-Nov-2015 16:55:12 CET-----------------------
An exception of category 'ProductNotFound' occurred while
   [0] Processing run: 1 lumi: 1 event: 1
   [1] Running path 'digi2raw_step'
   [2] Calling event method for module SiPixelDigiToRaw/'siPixelRawData'
Exception Message:
Principal::getByToken: Found zero products matching all criteria
Looking for type: edm::DetSetVector
Looking for module label: simSiPixelDigis
Looking for productInstanceName: 
   Additional Info:
      [a] If you wish to continue processing events after a ProductNotFound exception,
add "SkipEvent = cms.untracked.vstring('ProductNotFound')" to the "options" PSet in the configuration.
----- End Fatal Exception -------------------------------------------------

50202.0 step2

runTheMatrix-results/50202.0_TTbar_13+TTbar_13+DIGIUP15_PU50+RECOUP15_PU50+HARVESTUP15_PU50/step2_TTbar_13+TTbar_13+DIGIUP15_PU50+RECOUP15_PU50+HARVESTUP15_PU50.log
----- Begin Fatal Exception 12-Nov-2015 17:05:09 CET-----------------------
An exception of category 'ProductNotFound' occurred while
   [0] Processing run: 1 lumi: 1 event: 1
   [1] Running path 'digi2raw_step'
   [2] Calling event method for module SiPixelDigiToRaw/'siPixelRawData'
Exception Message:
Principal::getByToken: Found zero products matching all criteria
Looking for type: edm::DetSetVector
Looking for module label: simSiPixelDigis
Looking for productInstanceName: 
   Additional Info:
      [a] If you wish to continue processing events after a ProductNotFound exception,
add "SkipEvent = cms.untracked.vstring('ProductNotFound')" to the "options" PSet in the configuration.
----- End Fatal Exception -------------------------------------------------

25202.0 step2

runTheMatrix-results/25202.0_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25/step2_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25.log
----- Begin Fatal Exception 12-Nov-2015 17:05:32 CET-----------------------
An exception of category 'ProductNotFound' occurred while
   [0] Processing run: 1 lumi: 1 event: 1
   [1] Running path 'digi2raw_step'
   [2] Calling event method for module SiPixelDigiToRaw/'siPixelRawData'
Exception Message:
Principal::getByToken: Found zero products matching all criteria
Looking for type: edm::DetSetVector
Looking for module label: simSiPixelDigis
Looking for productInstanceName: 
   Additional Info:
      [a] If you wish to continue processing events after a ProductNotFound exception,
add "SkipEvent = cms.untracked.vstring('ProductNotFound')" to the "options" PSet in the configuration.
----- End Fatal Exception -------------------------------------------------

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12403/9689/summary.html

lveldere · 2015-11-12T18:42:10Z

please test

cmsbuild · 2015-11-12T18:46:17Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/9697/console

cmsbuild · 2015-11-12T18:46:19Z

Pull request #12403 was updated. @ssekmen, @lveldere, @civanch, @mdhildreth, @cmsbuild, @franzoni, @davidlange6 can you please check and sign again.

cmsbuild · 2015-11-12T20:37:42Z

+1
Tested at: b1bf851
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12403/9697/summary.html

cmsbuild · 2015-11-12T21:27:48Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12403/9697/summary.html

lveldere · 2015-11-13T08:38:17Z

+1

mdhildreth · 2015-11-15T03:24:28Z

should be ok...

mdhildreth · 2015-11-15T03:24:33Z

+1

fastsim: use fastsim era to define fastsim customs to mixing

cmsbuild added this to the Next CMSSW_8_0_X milestone Nov 12, 2015

cmsbuild added simulation-pending fastsim-pending operations-pending pending-signatures tests-pending orp-pending comparison-pending labels Nov 12, 2015

cmsbuild added tests-started and removed tests-pending labels Nov 12, 2015

cmsbuild added tests-rejected and removed tests-started labels Nov 12, 2015

Lukas added 2 commits November 12, 2015 19:39

fastsim: use fastsim era to define fastsim customs to mixing

18cc20e

fix typo

b1bf851

cmsbuild added tests-pending and removed tests-rejected labels Nov 12, 2015

cmsbuild added tests-started and removed tests-pending labels Nov 12, 2015

cmsbuild added tests-approved and removed tests-started labels Nov 12, 2015

cmsbuild removed the comparison-pending label Nov 12, 2015

cmsbuild added the comparison-available label Nov 12, 2015

cmsbuild added fastsim-approved and removed fastsim-pending labels Nov 13, 2015

cmsbuild added simulation-approved and removed simulation-pending labels Nov 15, 2015

davidlange6 added a commit that referenced this pull request Nov 15, 2015

Merge pull request #12403 from lveldere/fastsim-era-mixing

6c51220

fastsim: use fastsim era to define fastsim customs to mixing

davidlange6 merged commit 6c51220 into cms-sw:CMSSW_8_0_X Nov 15, 2015

slava77 mentioned this pull request Nov 17, 2015

Fastsim era global validation2 #12460

Closed

lveldere mentioned this pull request Dec 9, 2015

FastSim: use fastsim era to define customs to mixing (part2), includes fix to L1 emulator #12728

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fastsim: use fastsim era to define fastsim customs to mixing #12403

fastsim: use fastsim era to define fastsim customs to mixing #12403

lveldere commented Nov 12, 2015

lveldere commented Nov 12, 2015

cmsbuild commented Nov 12, 2015

cmsbuild commented Nov 12, 2015

cmsbuild commented Nov 12, 2015

lveldere commented Nov 12, 2015

cmsbuild commented Nov 12, 2015

cmsbuild commented Nov 12, 2015

cmsbuild commented Nov 12, 2015

cmsbuild commented Nov 12, 2015

lveldere commented Nov 13, 2015

mdhildreth commented Nov 15, 2015

mdhildreth commented Nov 15, 2015

fastsim: use fastsim era to define fastsim customs to mixing #12403

fastsim: use fastsim era to define fastsim customs to mixing #12403

Conversation

lveldere commented Nov 12, 2015

lveldere commented Nov 12, 2015

cmsbuild commented Nov 12, 2015

cmsbuild commented Nov 12, 2015

cmsbuild commented Nov 12, 2015

lveldere commented Nov 12, 2015

cmsbuild commented Nov 12, 2015

cmsbuild commented Nov 12, 2015

cmsbuild commented Nov 12, 2015

cmsbuild commented Nov 12, 2015

lveldere commented Nov 13, 2015

mdhildreth commented Nov 15, 2015

mdhildreth commented Nov 15, 2015