Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bsunanda:Run2-hcx49 First attempt of hexagonal geometry for HGCal #12407

Merged
merged 2 commits into from Nov 16, 2015

Conversation

bsunanda
Copy link
Contributor

Tested only for overlaps. Needs lot more work to make it useful for simulation (and then reconstruction)

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @bsunanda for CMSSW_8_0_X.

It involves the following packages:

Geometry/HGCalCommonData

@civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig this is something you requested to watch as well.
@Degano you are the release manager for this.

Following commands in first line of a comment are recognized

  • +1|approve[d]|sign[ed]: L1/L2's to approve it
  • -1|reject[ed]: L1/L2's to reject it
  • assign <category>[,<category>[,...]]: L1/L2's to request signatures from other categories
  • unassign <category>[,<category>[,...]]: L1/L2's to remove signatures from other categories
  • hold: L1/L2's to mark it as on hold
  • merge: L1/release managers to merge this request
  • [@cmsbuild,] please test: L1/L2 and selected users to start jenkins tests
  • [@cmsbuild,] please test with cms-sw/cmsdist#<PR>: L1/L2 and selected users to start jenkins tests using externals from cmsdist

@bsunanda
Copy link
Contributor Author

@cmsbuild Please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/9699/console

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@ianna
Copy link
Contributor

ianna commented Nov 13, 2015

@bsunanda - there are 34 very small overlaps reported by cmsShow. Note, an overlap reported only once per volume copy.

@bsunanda
Copy link
Contributor Author

@cmsbuild Please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/9713/console

@cmsbuild
Copy link
Contributor

Pull request #12407 was updated. @civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @davidlange6 can you please check and sign again.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@ianna
Copy link
Contributor

ianna commented Nov 16, 2015

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

i'm surprised that this is changing an existing geometry - hgcal developers do not rely on what was previously in v7 for anything?

@bsunanda
Copy link
Contributor Author

The earlier v7 was a bit pre-emptive. It was supposed to make ground for this one. The earlier v7 was to define the absorber thickness. The real structure is coming from this.


From: David Lange [notifications@github.com]
Sent: 16 November 2015 13:33
To: cms-sw/cmssw
Cc: Sunanda Banerjee
Subject: Re: [cmssw] bsunanda:Run2-hcx49 First attempt of hexagonal geometry for HGCal (#12407)

i'm surprised that this is changing an existing geometry - hgcal developers do not rely on what was previously in v7 for anything?


Reply to this email directly or view it on GitHubhttps://github.com//pull/12407#issuecomment-157014727.

@davidlange6
Copy link
Contributor

+1

Thanks for the confirmation.

cmsbuild added a commit that referenced this pull request Nov 16, 2015
bsunanda:Run2-hcx49 First attempt of hexagonal geometry for HGCal
@cmsbuild cmsbuild merged commit a5941fe into cms-sw:CMSSW_8_0_X Nov 16, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants