New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bsunanda:Run2-hcx49 First attempt of hexagonal geometry for HGCal #12407
Conversation
A new Pull Request was created by @bsunanda for CMSSW_8_0_X. It involves the following packages: Geometry/HGCalCommonData @civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @davidlange6 can you please review it and eventually sign? Thanks. Following commands in first line of a comment are recognized
|
@cmsbuild Please test |
The tests are being triggered in jenkins. |
@bsunanda - there are 34 very small overlaps reported by cmsShow. Note, an overlap reported only once per volume copy. |
@cmsbuild Please test |
The tests are being triggered in jenkins. |
Pull request #12407 was updated. @civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @davidlange6 can you please check and sign again. |
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar |
i'm surprised that this is changing an existing geometry - hgcal developers do not rely on what was previously in v7 for anything? |
The earlier v7 was a bit pre-emptive. It was supposed to make ground for this one. The earlier v7 was to define the absorber thickness. The real structure is coming from this. From: David Lange [notifications@github.com] i'm surprised that this is changing an existing geometry - hgcal developers do not rely on what was previously in v7 for anything? — |
+1 Thanks for the confirmation. |
bsunanda:Run2-hcx49 First attempt of hexagonal geometry for HGCal
Tested only for overlaps. Needs lot more work to make it useful for simulation (and then reconstruction)