Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding Dstar filter for enriched MC production #12408

Merged
merged 1 commit into from Dec 3, 2015

Conversation

vmariani
Copy link
Contributor

D* filter for official enriched Monte Carlo samples for 7_1_X

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @vmariani for CMSSW_7_1_X.

It involves the following packages:

GeneratorInterface/ExternalDecays
GeneratorInterface/GenFilters

@vciulli, @covarell, @thuer, @cmsbuild, @bendavid, @davidlange6, @govoni can you please review it and eventually sign? Thanks.
@inugent, @mkirsano this is something you requested to watch as well.
@Degano you are the release manager for this.

Following commands in first line of a comment are recognized

  • +1|approve[d]|sign[ed]: L1/L2's to approve it
  • -1|reject[ed]: L1/L2's to reject it
  • assign <category>[,<category>[,...]]: L1/L2's to request signatures from other categories
  • unassign <category>[,<category>[,...]]: L1/L2's to remove signatures from other categories
  • hold: L1/L2's to mark it as on hold
  • merge: L1/release managers to merge this request
  • [@cmsbuild,] please test: L1/L2 and selected users to start jenkins tests
  • [@cmsbuild,] please test with cms-sw/cmsdist#<PR>: L1/L2 and selected users to start jenkins tests using externals from cmsdist

@govoni
Copy link
Contributor

govoni commented Nov 13, 2015

+1

@bendavid
Copy link
Contributor

Is this functionality not contained in any of the existing filters?

If this is not already in 80x, then an additional pull request needs to be opened for 80x.

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/9700/console

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12408/9700/summary.html

There are some workflows for which there are errors in the baseline:
4.22 step 2
4.53 step 2
1003.0 step 2
50202.0 step 3
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@vmariani
Copy link
Contributor Author

Dear Josh,

this filter is not contained in any of the existing filters.
I just opened the pull request for 8_0_x.

Regards,
Valentina

Il 13/11/2015 10.26, Josh Bendavid ha scritto:

Is this functionality not contained in any of the existing filters?

If this is not already in 80x, then an additional pull request needs
to be opened for 80x.


Reply to this email directly or view it on GitHub
#12408 (comment).

@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request Dec 3, 2015
adding Dstar filter for enriched MC production
@cmsbuild cmsbuild merged commit 6b2a6ec into cms-sw:CMSSW_7_1_X Dec 3, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants