New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding Dstar filter for enriched MC production #12409
Conversation
A new Pull Request was created by @vmariani for CMSSW_8_0_X. It involves the following packages: GeneratorInterface/ExternalDecays @vciulli, @covarell, @thuer, @cmsbuild, @bendavid, @davidlange6, @govoni can you please review it and eventually sign? Thanks. Following commands in first line of a comment are recognized
|
+1 |
The tests are being triggered in jenkins. |
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar |
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar |
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar |
@@ -0,0 +1,161 @@ | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vmariani - why this is not extending an existing filter with added functionality?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We tried to use PythiaDauFilter and PythiaFilter but in our use case we need the link between mother-daugther-nephew that combining the two filters separetely doesn't work.
@vmariani - yes, I understand that you did not have the needed functionality with the existing filters. But could you not simply extend the functionality of one of them to meet your needs? (and not introducing a completely new filter) |
I can't extend the functionality of one of the existing filters because Il 19/11/2015 11.18, David Lange ha scritto:
|
+1 |
adding Dstar filter for enriched MC production
D* filter for official enriched Monte Carlo samples for 8_0_X