Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding Dstar filter for enriched MC production #12409

Merged
merged 1 commit into from Dec 3, 2015

Conversation

vmariani
Copy link
Contributor

D* filter for official enriched Monte Carlo samples for 8_0_X

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @vmariani for CMSSW_8_0_X.

It involves the following packages:

GeneratorInterface/ExternalDecays
GeneratorInterface/GenFilters

@vciulli, @covarell, @thuer, @cmsbuild, @bendavid, @davidlange6, @govoni can you please review it and eventually sign? Thanks.
@inugent, @mkirsano this is something you requested to watch as well.
@Degano you are the release manager for this.

Following commands in first line of a comment are recognized

  • +1|approve[d]|sign[ed]: L1/L2's to approve it
  • -1|reject[ed]: L1/L2's to reject it
  • assign <category>[,<category>[,...]]: L1/L2's to request signatures from other categories
  • unassign <category>[,<category>[,...]]: L1/L2's to remove signatures from other categories
  • hold: L1/L2's to mark it as on hold
  • merge: L1/release managers to merge this request
  • [@cmsbuild,] please test: L1/L2 and selected users to start jenkins tests
  • [@cmsbuild,] please test with cms-sw/cmsdist#<PR>: L1/L2 and selected users to start jenkins tests using externals from cmsdist

@govoni
Copy link
Contributor

govoni commented Nov 13, 2015

+1

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/9702/console

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@@ -0,0 +1,161 @@

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vmariani - why this is not extending an existing filter with added functionality?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We tried to use PythiaDauFilter and PythiaFilter but in our use case we need the link between mother-daugther-nephew that combining the two filters separetely doesn't work.

@davidlange6
Copy link
Contributor

@vmariani - yes, I understand that you did not have the needed functionality with the existing filters.

But could you not simply extend the functionality of one of them to meet your needs? (and not introducing a completely new filter)

@vmariani
Copy link
Contributor Author

I can't extend the functionality of one of the existing filters because
the requests we need are quite different.

Il 19/11/2015 11.18, David Lange ha scritto:

@vmariani https://github.com/vmariani - yes, I understand that you
did not have the needed functionality with the existing filters.

But could you not simply extend the functionality of one of them to
meet your needs? (and not introducing a completely new filter)


Reply to this email directly or view it on GitHub
#12409 (comment).

@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request Dec 3, 2015
adding Dstar filter for enriched MC production
@cmsbuild cmsbuild merged commit 05d2fb3 into cms-sw:CMSSW_8_0_X Dec 3, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants