Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pr hi gt fixes and remove customs 75x #12475

Conversation

mulhearn
Copy link
Contributor

This combines GT update (which includes latest HI tags for CaloParams) and the removal of customization which set CaloParams from local config file.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mulhearn for CMSSW_7_5_X.

It involves the following packages:

Configuration/AlCa
L1Trigger/L1TCommon

@diguida, @cerminar, @cmsbuild, @franzoni, @mmusich, @mulhearn, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @Martin-Grunewald this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

Following commands in first line of a comment are recognized

  • +1|approve[d]|sign[ed]: L1/L2's to approve it
  • -1|reject[ed]: L1/L2's to reject it
  • assign <category>[,<category>[,...]]: L1/L2's to request signatures from other categories
  • unassign <category>[,<category>[,...]]: L1/L2's to remove signatures from other categories
  • hold: L1/all L2's/release manager to mark it as on hold
  • unhold: L1/user who put this PR on hold
  • merge: L1/release managers to merge this request
  • [@cmsbuild,] please test: L1/L2 and selected users to start jenkins tests
  • [@cmsbuild,] please test with cms-sw/cmsdist#<PR>: L1/L2 and selected users to start jenkins tests using externals from cmsdist

@mulhearn
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/9812/console

@mulhearn
Copy link
Contributor Author

Latests DQM comparisons revealed a residual problem with HI conditions, which this last commit of Alex's addresses.

@mulhearn
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/9816/console

@cmsbuild
Copy link
Contributor

Pull request #12475 was updated. @diguida, @cerminar, @cmsbuild, @franzoni, @mmusich, @mulhearn, @davidlange6 can you please check and sign again.

@mulhearn
Copy link
Contributor Author

+1

@cmsbuild
Copy link
Contributor

@mmusich
Copy link
Contributor

mmusich commented Nov 18, 2015

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_7_6_X is complete. This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_7_6_X is complete. This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@slava77
Copy link
Contributor

slava77 commented Nov 19, 2015

@mulhearn please update the title of the PR to something readable [use "Edit" button at the top]
Please add a note about #12474 included in here

@slava77
Copy link
Contributor

slava77 commented Nov 19, 2015

merge

jenkins showed no differences
I ran locally adding 261626 and 251721 processed with HeavyIonsRun2 setup and 75X_dataRun2_PromptHI_v1 GT: nothing changed.
Run2 data processing in relval 134.* workflows moved around due to IOV updates following the GT snapshot time updates

cmsbuild added a commit that referenced this pull request Nov 19, 2015
…ove-customs-75x

Pr hi gt fixes and remove customs 75x
@cmsbuild cmsbuild merged commit b3785a8 into cms-sw:CMSSW_7_5_X Nov 19, 2015
@mulhearn mulhearn deleted the pr-hi-gt-fixes-and-remove-customs-75x branch November 19, 2015 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants