Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 2 new GenFilters for use by HI photon team #12510

Merged

Conversation

harmonicoscillator
Copy link
Contributor

These two gen filters for Pythia8 are meant to mimic the older ones used with Pyquen, which can be found here:
https://github.com/cms-sw/cmssw/blob/CMSSW_7_5_X/GeneratorInterface/HiGenCommon/src/EcalGenEvtSelector.cc
https://github.com/cms-sw/cmssw/blob/CMSSW_7_5_X/GeneratorInterface/HiGenCommon/src/EcalGenEvtSelectorFrag.cc

@bi-ran has done some sanity checking between the old filters and new filters which can be found here:
https://twiki.cern.ch/twiki/pub/CMS/MITHIGAnalysis2015/MCFilters.pdf

We would like to include these filters in the 75X series to be used for HI MC production.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @richard-cms (R. Alex Barbieri) for CMSSW_8_0_X.

It involves the following packages:

GeneratorInterface/GenFilters

@vciulli, @covarell, @thuer, @cmsbuild, @bendavid, @davidlange6, @govoni can you please review it and eventually sign? Thanks.
@mkirsano this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

Following commands in first line of a comment are recognized

  • +1|approve[d]|sign[ed]: L1/L2's to approve it
  • -1|reject[ed]: L1/L2's to reject it
  • assign <category>[,<category>[,...]]: L1/L2's to request signatures from other categories
  • unassign <category>[,<category>[,...]]: L1/L2's to remove signatures from other categories
  • hold: L1/all L2's/release manager to mark it as on hold
  • unhold: L1/user who put this PR on hold
  • merge: L1/release managers to merge this request
  • [@cmsbuild,] please test: L1/L2 and selected users to start jenkins tests
  • [@cmsbuild,] please test with cms-sw/cmsdist#<PR>: L1/L2 and selected users to start jenkins tests using externals from cmsdist

@covarell
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/9922/console

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

@cmsbuild
Copy link
Contributor

R. Alex Barbieri added 2 commits November 27, 2015 16:42
add HINEcalGenEvtSelector, based on pyquen version

(cherry picked from commit c88da8c)
@harmonicoscillator
Copy link
Contributor Author

Rebased on newest 8_0_X to avoid conflict with PythiaFilterHT

@cmsbuild
Copy link
Contributor

Pull request #12510 was updated. @vciulli, @covarell, @thuer, @cmsbuild, @bendavid, @davidlange6, @govoni can you please check and sign again.

@covarell
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/9995/console

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

davidlange6 added a commit that referenced this pull request Dec 16, 2015
Add 2 new GenFilters for use by HI photon team
@davidlange6 davidlange6 merged commit 6ce2e14 into cms-sw:CMSSW_8_0_X Dec 16, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants