Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for on Track Cluster plots in Offline Pixel DQM for HI runs #12603

Merged
merged 1 commit into from Nov 30, 2015
Merged

Fix for on Track Cluster plots in Offline Pixel DQM for HI runs #12603

merged 1 commit into from Nov 30, 2015

Conversation

fioriNTU
Copy link
Contributor

Important fixies for Pixel DQM in HI runs, it brings back OnTrack Clusters plots and Hit efficiency plots in Pixel Offline DQM. The primary vertex label and tracks label in previous version were wrong for HI running

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @fioriNTU for CMSSW_7_5_X.

It involves the following packages:

DQM/SiPixelCommon
DQM/SiPixelMonitorTrack

@cmsbuild, @vanbesien, @deguio, @davidlange6 can you please review it and eventually sign? Thanks.
@threus this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

Following commands in first line of a comment are recognized

  • +1|approve[d]|sign[ed]: L1/L2's to approve it
  • -1|reject[ed]: L1/L2's to reject it
  • assign <category>[,<category>[,...]]: L1/L2's to request signatures from other categories
  • unassign <category>[,<category>[,...]]: L1/L2's to remove signatures from other categories
  • hold: L1/all L2's/release manager to mark it as on hold
  • unhold: L1/user who put this PR on hold
  • merge: L1/release managers to merge this request
  • [@cmsbuild,] please test: L1/L2 and selected users to start jenkins tests
  • [@cmsbuild,] please test with cms-sw/cmsdist#<PR>: L1/L2 and selected users to start jenkins tests using externals from cmsdist

@fioriNTU
Copy link
Contributor Author

@davidlange6 @deguio these are important fixes for Pixel Offline DQM, would be very important to have it merged as soon as possible.

@slava77
Copy link
Contributor

slava77 commented Nov 30, 2015

@cmsbuild please test
@fioriNTU please describe in more details ("important fix" is not descriptive enough)

@fioriNTU
Copy link
Contributor Author

@slava77 this PR brings back OnTrack Clusters plots and Hit efficiency plots in Pixel Offline DQM. The primary vertex label and tracks label in previous version were wrong for HI running.

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/10017/console

@deguio
Copy link
Contributor

deguio commented Nov 30, 2015

+1
provided it passes the tests.
please submit for 76 and 80 as well.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs after it passes the integration tests and once validation in the development release cycle CMSSW_7_6_X is complete. This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

@slava77
Copy link
Contributor

slava77 commented Nov 30, 2015

@fioriNTU please update the PR subject to be better formatted and more descriptive (there is an "Edit" button at the top of the page)

@fioriNTU fioriNTU changed the title Pix hi fix75X Fix for on Track Cluster plots in Offline Pixel DQM for HI runs Nov 30, 2015
@slava77
Copy link
Contributor

slava77 commented Nov 30, 2015

merge

checked locally: pixel plots now show up with filled in the HI workflow; other workflows are not affected.

cmsbuild added a commit that referenced this pull request Nov 30, 2015
Fix for on Track Cluster plots in Offline Pixel DQM for HI runs
@cmsbuild cmsbuild merged commit a4eb75e into cms-sw:CMSSW_7_5_X Nov 30, 2015
@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants