bsunanda:Run2-hcx55 Changes to HO Calibration code due to Gobinda

[bsunanda]

Changes to HO calibration code as now used

[cmsbuild]

A new Pull Request was created by @bsunanda for CMSSW_8_0_X.

It involves the following packages:

Calibration/HcalAlCaRecoProducers
Calibration/HcalCalibAlgos
DataFormats/HcalCalibObjects

@diguida, @cerminar, @cmsbuild, @franzoni, @mmusich, @davidlange6 can you please review it and eventually sign? Thanks.
@slava77, @Degano, @smuzaffar you are the release manager for this.

Following commands in first line of a comment are recognized

• +1|approve[d]|sign[ed]: L1/L2's to approve it
• -1|reject[ed]: L1/L2's to reject it
• assign <category>[,<category>[,...]]: L1/L2's to request signatures from other categories
• unassign <category>[,<category>[,...]]: L1/L2's to remove signatures from other categories
• hold: L1/all L2's/release manager to mark it as on hold
• unhold: L1/user who put this PR on hold
• merge: L1/release managers to merge this request
• [@cmsbuild,] please test: L1/L2 and selected users to start jenkins tests
• [@cmsbuild,] please test with cms-sw/cmsdist#<PR>: L1/L2 and selected users to start jenkins tests using externals from cmsdist

[bsunanda]

@cmsbuild Please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/10054/console

[cmsbuild]

-1
Tested at: 518b0df
I found a compilation error while trying to compile with clang:
I used this command:
scram b vclean && scram build -k -j 8 USER_CXXFLAGS='-fsyntax-only' COMPILER='llvm compile'

^
28 warnings generated.
>> Compiling edm plugin /tmp/cmsbuild/workspace/ib-any-integration/CMSSW_8_0_X_2015-11-30-2300/src/Calibration/HcalAlCaRecoProducers/plugins/AlCaIsoTracksFilter.cc 
>> Compiling edm plugin /tmp/cmsbuild/workspace/ib-any-integration/CMSSW_8_0_X_2015-11-30-2300/src/Calibration/HcalAlCaRecoProducers/plugins/PrescalerFHN.cc 
>> Compiling LCG dictionary: tmp/slc6_amd64_gcc493/src/Calibration/HcalCalibAlgos/src/CalibrationHcalCalibAlgos/a/CalibrationHcalCalibAlgos_xr.cc
/tmp/cmsbuild/workspace/ib-any-integration/CMSSW_8_0_X_2015-11-30-2300/src/Calibration/HcalAlCaRecoProducers/src/AlCaHOCalibProducer.cc:154:11: error: unused variable 'nchnmx' [-Werror,-Wunused-const-variable]
const int nchnmx = 10;
          ^
/tmp/cmsbuild/workspace/ib-any-integration/CMSSW_8_0_X_2015-11-30-2300/src/Calibration/HcalAlCaRecoProducers/src/AlCaHOCalibProducer.cc:157:11: error: unused variable 'nsigpk' [-Werror,-Wunused-const-variable]
const int nsigpk = 7;
          ^


you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12629/10054/summary.html

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12629/10054/summary.html

[cmsbuild]

Pull request #12629 was updated. @diguida, @cerminar, @cmsbuild, @franzoni, @mmusich, @davidlange6 can you please check and sign again.

[bsunanda]

@cmsbuild Please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/10162/console

[cmsbuild]

-1
Tested at: 712636a
I found a compilation error while trying to compile with clang:
I used this command:
scram b vclean && scram build -k -j 8 USER_CXXFLAGS='-fsyntax-only' COMPILER='llvm compile'

                                 ^
:155:1: note: expanded from here
boost_concept_check903
^
28 warnings generated.
/tmp/cmsbuild/workspace/ib-any-integration/CMSSW_8_0_X_2015-12-04-1100/src/Calibration/HcalAlCaRecoProducers/src/AlCaHOCalibProducer.cc:158:11: error: unused variable 'nstrbn' [-Werror,-Wunused-const-variable]
const int nstrbn = 0;
          ^
/tmp/cmsbuild/workspace/ib-any-integration/CMSSW_8_0_X_2015-12-04-1100/src/Calibration/HcalAlCaRecoProducers/src/AlCaHOCalibProducer.cc:159:11: error: unused variable 'ntrgp_gm' [-Werror,-Wunused-const-variable]
const int ntrgp_gm = 11;
          ^


you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12629/10162/summary.html

[bsunanda]

@cmsbuild Please test

[mmusich]

please test
problem with missing HI Raw data should be gone

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/10767/console

[cmsbuild]

+1
Tested at: 1f2982a
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12629/10767/summary.html

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12629/10767/summary.html

[franzoni]

+1

@bsunanda thanks for the update
the test passed and pathALCARECOHcalCalHO is in the schedule On the limited statistics (and Mi) of the bot test, no events pass the selection.
Given the trigger bits the HcalCalHO producer selects on ():
'HcalCalHO'
'HLT_Mu24_v', 'HLT_Mu30_v_', 'HLT_IsoMu_', 'HLT_DoubleMu6_v_', 'HLT_DoubleMu7_v_'
and that the bot-test runs on 100 MinBias events from 2011, it's possible that none of those HLT paths fired.
Have you seen events passing the selections ?

(*) The GT used is: 80X_dataRun2_v2

conddb list 80X_dataRun2_v2 | grep AlCaReco
=> AlCaRecoHLTpaths8e29_1e31_v20_offline

which points to: https://twiki.cern.ch/twiki/bin/view/CMSPublic/SWGuideAlCaRecoTriggerBits
'HcalCalHO' 'HLT_Mu24_v_', 'HLT_Mu30_v_', 'HLT_IsoMu_', 'HLT_DoubleMu6_v_', 'HLT_DoubleMu7_v*'

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

[davidlange6]

@bsunanda - could you clarify why all of the BuildFile changes are needed?

[bsunanda]

This package were developed by several people each adding requirements in the BuildFile. It became a bit messy to follow them and so I tried to put the things in some order so that any additional requirement in future can be visually easy to be put in.

---

From: David Lange [notifications@github.com]
Sent: 28 January 2016 13:23
To: cms-sw/cmssw
Cc: Sunanda Banerjee
Subject: Re: [cmssw] bsunanda:Run2-hcx55 Changes to HO Calibration code due to Gobinda (#12629)

@bsunandahttps://github.com/bsunanda - could you clarify why all of the BuildFile changes are needed?

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/12629#issuecomment-176154212.

[davidlange6]

+1