Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for heavyIon object in both embedded and non-emb. HI samples #12660

Merged
merged 8 commits into from
Dec 8, 2015

Conversation

yetkinyilmaz
Copy link
Contributor

Running pdigi_hi for Hydjet samples so that the input for the heavyIon object is produced which is (CrossingFrame) by the same module in both embedded and non-embedded HI workflows.

pdigi_hi is added, and the relval workflows adjusted accordingly.

Tested workflows: 140, 145, 300, 140.53, in addition to those in runTheMatrix.py -s

Needed for RelVals, and especially needed for the release for MC DIGI campaign.

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 3, 2015

A new Pull Request was created by @yetkinyilmaz for CMSSW_7_5_X.

It involves the following packages:

Configuration/PyReleaseValidation
Configuration/StandardSequences
SimGeneral/MixingModule

@civanch, @boudoul, @franzoni, @mdhildreth, @fabozzi, @cmsbuild, @srimanob, @hengne, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @wmtan, @makortel, @GiacomoSguazzoni, @rovere, @VinInn, @Martin-Grunewald, @cerati, @dgulhan this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

Following commands in first line of a comment are recognized

  • +1|approve[d]|sign[ed]: L1/L2's to approve it
  • -1|reject[ed]: L1/L2's to reject it
  • assign <category>[,<category>[,...]]: L1/L2's to request signatures from other categories
  • unassign <category>[,<category>[,...]]: L1/L2's to remove signatures from other categories
  • hold: L1/all L2's/release manager to mark it as on hold
  • unhold: L1/user who put this PR on hold
  • merge: L1/release managers to merge this request
  • [@cmsbuild,] please test: L1/L2 and selected users to start jenkins tests
  • [@cmsbuild,] please test with cms-sw/cmsdist#<PR>: L1/L2 and selected users to start jenkins tests using externals from cmsdist

@diguida
Copy link
Contributor

diguida commented Dec 4, 2015

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 4, 2015

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/10129/console

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 4, 2015

-1
Tested at: bbe27f9
When I ran the RelVals I found an error in the following worklfows:
140.53 step1

DAS Error

1000.0 step1

DAS Error

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12660/10129/summary.html

@hengne
Copy link
Contributor

hengne commented Dec 4, 2015

please test

DAS error can be temporary.

@hengne
Copy link
Contributor

hengne commented Dec 4, 2015

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 4, 2015

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/10130/console

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 4, 2015

Pull request #12660 was updated. @civanch, @boudoul, @franzoni, @mdhildreth, @fabozzi, @cmsbuild, @srimanob, @deguio, @vanbesien, @hengne, @davidlange6 can you please check and sign again.

@yetkinyilmaz
Copy link
Contributor Author

I have merged @rkunnawa's fixes for the segfault in jet validation.

@diguida
Copy link
Contributor

diguida commented Dec 4, 2015

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 4, 2015

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/10149/console

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 4, 2015

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 4, 2015

@hengne
Copy link
Contributor

hengne commented Dec 4, 2015

+1

@civanch
Copy link
Contributor

civanch commented Dec 4, 2015

+1

@deguio
Copy link
Contributor

deguio commented Dec 5, 2015

changes are fine for DQM, but are there corresponding PR for 76 and 80?

@yetkinyilmaz
Copy link
Contributor Author

@deguio , this PR is only relevant for CMSSW_7_5_X, because the mixing workflows in the other releases are different. Those releases do need updates as well, however it is not this bugfix, there will have to be more work for those.

@yetkinyilmaz
Copy link
Contributor Author

Hi. Can the remaining signatures comment? We need this in CMSSW_7_5_7_patch4.

@deguio
Copy link
Contributor

deguio commented Dec 8, 2015

+1

davidlange6 added a commit that referenced this pull request Dec 8, 2015
Fix for heavyIon object in both embedded and non-emb. HI samples
@davidlange6 davidlange6 merged commit 5919cb7 into cms-sw:CMSSW_7_5_X Dec 8, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants