-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for heavyIon object in both embedded and non-emb. HI samples #12660
Conversation
A new Pull Request was created by @yetkinyilmaz for CMSSW_7_5_X. It involves the following packages: Configuration/PyReleaseValidation @civanch, @boudoul, @franzoni, @mdhildreth, @fabozzi, @cmsbuild, @srimanob, @hengne, @davidlange6 can you please review it and eventually sign? Thanks. Following commands in first line of a comment are recognized
|
please test |
The tests are being triggered in jenkins. |
-1 DAS Error 1000.0 step1 DAS Error you can see the results of the tests here: |
please test DAS error can be temporary. |
please test |
The tests are being triggered in jenkins. |
Pull request #12660 was updated. @civanch, @boudoul, @franzoni, @mdhildreth, @fabozzi, @cmsbuild, @srimanob, @deguio, @vanbesien, @hengne, @davidlange6 can you please check and sign again. |
I have merged @rkunnawa's fixes for the segfault in jet validation. |
please test |
The tests are being triggered in jenkins. |
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
+1 |
+1 |
changes are fine for DQM, but are there corresponding PR for 76 and 80? |
@deguio , this PR is only relevant for CMSSW_7_5_X, because the mixing workflows in the other releases are different. Those releases do need updates as well, however it is not this bugfix, there will have to be more work for those. |
Hi. Can the remaining signatures comment? We need this in CMSSW_7_5_7_patch4. |
+1 |
Fix for heavyIon object in both embedded and non-emb. HI samples
Running pdigi_hi for Hydjet samples so that the input for the heavyIon object is produced which is (CrossingFrame) by the same module in both embedded and non-embedded HI workflows.
pdigi_hi is added, and the relval workflows adjusted accordingly.
Tested workflows: 140, 145, 300, 140.53, in addition to those in runTheMatrix.py -s
Needed for RelVals, and especially needed for the release for MC DIGI campaign.