Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add script to dump LHE header to file #12685

Merged
merged 1 commit into from Dec 14, 2015

Conversation

bendavid
Copy link
Contributor

@bendavid bendavid commented Dec 7, 2015

No description provided.

@bendavid
Copy link
Contributor Author

bendavid commented Dec 7, 2015

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 7, 2015

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/10176/console

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 7, 2015

This pull request is fully signed and it will be integrated in one of the next CMSSW_5_3_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 7, 2015

A new Pull Request was created by @bendavid (Josh Bendavid) for CMSSW_5_3_X.

It involves the following packages:

GeneratorInterface/LHEInterface

@cmsbuild, @davidlange6 can you please review it and eventually sign? Thanks.
@mkirsano this is something you requested to watch as well.
@slava77, @smuzaffar you are the release manager for this.

Following commands in first line of a comment are recognized

  • +1|approve[d]|sign[ed]: L1/L2's to approve it
  • -1|reject[ed]: L1/L2's to reject it
  • assign <category>[,<category>[,...]]: L1/L2's to request signatures from other categories
  • unassign <category>[,<category>[,...]]: L1/L2's to remove signatures from other categories
  • hold: L1/all L2's/release manager to mark it as on hold
  • unhold: L1/user who put this PR on hold
  • merge: L1/release managers to merge this request
  • [@cmsbuild,] please test: L1/L2 and selected users to start jenkins tests
  • [@cmsbuild,] please test with cms-sw/cmsdist#<PR>: L1/L2 and selected users to start jenkins tests using externals from cmsdist

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 7, 2015

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 7, 2015

@@ -43,8 +46,12 @@ void LHEWriter::beginRun(const edm::Run &run, const edm::EventSetup &es)
{
edm::Handle<LHERunInfoProduct> product;
run.getByLabel("source", product);

if (!product.isValid()) {
run.getByLabel("externalLHEProducer", product);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs a consumes, no? @bendavid

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Sorry, missed this before).
This being 53x I think not.

I'll make sure it gets added when this is put in the newer releases.

@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request Dec 14, 2015
Add script to dump LHE header to file
@cmsbuild cmsbuild merged commit f734bad into cms-sw:CMSSW_5_3_X Dec 14, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants