New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add particle list files and update decay files for BPH (Bmm) #12686
Conversation
A new Pull Request was created by @heppye (Ye Chen) for CMSSW_7_1_X. It involves the following packages: GeneratorInterface/ExternalDecays @vciulli, @covarell, @thuer, @cmsbuild, @bendavid, @davidlange6, @govoni can you please review it and eventually sign? Thanks. Following commands in first line of a comment are recognized
|
Hi Ye, ...V4.dec implies that we need V1, V2, V3 AND V4 in the same release. Is it really the case? |
@covarell , it is for the usage of documentation as V3 has already been used for runIIWinter15GS official generation. V4 have pdg2015 bs mixing parameters updates comparing to V3 (made by Andrey) and it should be the recent recommended one.V2 is for pythia6 and have a angular distribution update comparing to V1. V1V2 might could be dropped. Do you have a better suggestion for the naming? |
Ok, could you just drop V1 and V2 in this commit? |
+1 |
The same must be done for 80X commit |
The tests are being triggered in jenkins. |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar |
sounds like there is no need for V3 to change to V4 - just change V3. The release version will then tell you which version of the file has been used (as is true for the rest of CMSSW)
|
@davidlange6 , for future studies, it might not be easy to notice those changes in the decay file. However, I might commit the changes if it is ok to you. |
@davidlange6 , done. @covarell , could you please check again? thanks. |
-1 runTheMatrix-results/1001.0_RunMinBias2011A+RunMinBias2011A+TIER0EXP+ALCAEXP+ALCAHARVD/step2_RunMinBias2011A+RunMinBias2011A+TIER0EXP+ALCAEXP+ALCAHARVD.log you can see the results of the tests here: |
@cmsbuild , the local tests of those patches are fine. Could it be possible that 1001.0 step2 is not relevant to this PR? |
+1 |
The tests are being triggered in jenkins. |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar |
+1 |
Add particle list files and update decay files for BPH (Bmm)
Add particle list files and update decay files for BPH (Bmm)