Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add particle list files and update decay files for BPH (Bmm) #12686

Merged
merged 4 commits into from Jan 11, 2016
Merged

Add particle list files and update decay files for BPH (Bmm) #12686

merged 4 commits into from Jan 11, 2016

Conversation

heppye
Copy link
Contributor

@heppye heppye commented Dec 7, 2015

Add particle list files and update decay files for BPH (Bmm)

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 7, 2015

A new Pull Request was created by @heppye (Ye Chen) for CMSSW_7_1_X.

It involves the following packages:

GeneratorInterface/ExternalDecays

@vciulli, @covarell, @thuer, @cmsbuild, @bendavid, @davidlange6, @govoni can you please review it and eventually sign? Thanks.
@inugent, @mkirsano this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

Following commands in first line of a comment are recognized

  • +1|approve[d]|sign[ed]: L1/L2's to approve it
  • -1|reject[ed]: L1/L2's to reject it
  • assign <category>[,<category>[,...]]: L1/L2's to request signatures from other categories
  • unassign <category>[,<category>[,...]]: L1/L2's to remove signatures from other categories
  • hold: L1/all L2's/release manager to mark it as on hold
  • unhold: L1/user who put this PR on hold
  • merge: L1/release managers to merge this request
  • [@cmsbuild,] please test: L1/L2 and selected users to start jenkins tests
  • [@cmsbuild,] please test with cms-sw/cmsdist#<PR>: L1/L2 and selected users to start jenkins tests using externals from cmsdist

@covarell
Copy link
Contributor

covarell commented Dec 7, 2015

Hi Ye,

...V4.dec implies that we need V1, V2, V3 AND V4 in the same release. Is it really the case?
If so, maybe a better naming would help future users to understand the differences between the four versions.

@heppye
Copy link
Contributor Author

heppye commented Dec 7, 2015

@covarell , it is for the usage of documentation as V3 has already been used for runIIWinter15GS official generation. V4 have pdg2015 bs mixing parameters updates comparing to V3 (made by Andrey) and it should be the recent recommended one.V2 is for pythia6 and have a angular distribution update comparing to V1. V1V2 might could be dropped. Do you have a better suggestion for the naming?

@covarell
Copy link
Contributor

covarell commented Dec 7, 2015

Ok, could you just drop V1 and V2 in this commit?

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 7, 2015

Pull request #12686 was updated. @vciulli, @covarell, @thuer, @cmsbuild, @bendavid, @davidlange6, @govoni can you please check and sign again.

@covarell
Copy link
Contributor

covarell commented Dec 7, 2015

+1

@covarell
Copy link
Contributor

covarell commented Dec 7, 2015

The same must be done for 80X commit

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 7, 2015

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/10178/console

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 7, 2015

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

@heppye
Copy link
Contributor Author

heppye commented Dec 7, 2015

@covarell , many thanks for the prompt response. Same commits also done to #12683.

@davidlange6
Copy link
Contributor

sounds like there is no need for V3 to change to V4 - just change V3. The release version will then tell you which version of the file has been used (as is true for the rest of CMSSW)

On Dec 7, 2015, at 11:29 AM, Ye Chen notifications@github.com wrote:

@covarell , it is for the usage of documentation as V3 has already been used for runIIWinter15GS official generation. V4 have pdg2015 bs mixing parameters updates comparing to V3 (made by Andrey) and it should be the recent recommended one.V2 is for pythia6 and have a angular distribution update comparing to V1. V1V2 might could be dropped. Do you have a better suggestion for the naming?


Reply to this email directly or view it on GitHub.

@heppye
Copy link
Contributor Author

heppye commented Dec 7, 2015

@davidlange6 , for future studies, it might not be easy to notice those changes in the decay file. However, I might commit the changes if it is ok to you.

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 7, 2015

Pull request #12686 was updated. @vciulli, @covarell, @thuer, @cmsbuild, @bendavid, @davidlange6, @govoni can you please check and sign again.

@heppye
Copy link
Contributor Author

heppye commented Dec 7, 2015

@davidlange6 , done. @covarell , could you please check again? thanks.

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 7, 2015

-1
Tested at: 80a1b83
When I ran the RelVals I found an error in the following worklfows:
1001.0 step2

runTheMatrix-results/1001.0_RunMinBias2011A+RunMinBias2011A+TIER0EXP+ALCAEXP+ALCAHARVD/step2_RunMinBias2011A+RunMinBias2011A+TIER0EXP+ALCAEXP+ALCAHARVD.log

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12686/10178/summary.html

@heppye
Copy link
Contributor Author

heppye commented Dec 7, 2015

@cmsbuild , the local tests of those patches are fine. Could it be possible that 1001.0 step2 is not relevant to this PR?

@covarell
Copy link
Contributor

covarell commented Dec 7, 2015

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 7, 2015

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/10183/console

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 7, 2015

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 7, 2015

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 7, 2015

@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request Jan 11, 2016
Add particle list files and update decay files for BPH (Bmm)
@cmsbuild cmsbuild merged commit abb92a0 into cms-sw:CMSSW_7_1_X Jan 11, 2016
@heppye heppye deleted the patch-17 branch April 3, 2016 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants