Fix to PFEgammaAlgo #12797
Fix to PFEgammaAlgo #12797
Conversation
|
A new Pull Request was created by @matteosan1 (Matteo Sani) for CMSSW_8_0_X. It involves the following packages: RecoParticleFlow/PFProducer @cmsbuild, @cvuosalo, @davidlange6, @slava77 can you please review it and eventually sign? Thanks. Following commands in first line of a comment are recognized
|
| @@ -1408,12 +1407,16 @@ initializeProtoCands(std::list<PFEGammaAlgo::ProtoEGObject>& egobjs) { | |||
| } | |||
| }// loop over tracks in primary vertex | |||
| // if associated to good non-GSF matched track remove this cluster | |||
| if( Algo < reco::TrackBase::pixelLessStep && nexhits == 0 && fromprimaryvertex ) { | |||
| if( PFTrackAlgoTools::isNotPixelLessStep(trackref->algo()) && nexhits == 0 && fromprimaryvertex ) { | |||
There was a problem hiding this comment.
the name is confusing
tobtec etc are "not isNotPixelLessStep" in this case.
It's better to call it by purpose rather than by the actual implementation:
isGoodForEGMPrimary or something like that
|
The tests are being triggered in jenkins. |
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar |
cmsbuild
added
reconstruction-approved
fully-signed
and removed
pending-signatures
reconstruction-pending
labels
|
@slava77 Yes, this should be the last occurrence inside @matteosan1 Thanks! |
|
+1 |
Fix to PFEGammaAlgo to be compliant with PFTrackAlgoTools.