Remove module circular dependency check from EventPrincipal #12802
Conversation
We previously checked that a module wasn't indirectly calling itself in unscheduled via a run time check. With the requirements on consumes calls, we now check for circular dependencies before running the job. In addition, this implementation would not be thread safe. However, if we ever did need to add back a runtime check we could use the Context information instead.
|
A new Pull Request was created by @Dr15Jones (Chris Jones) for CMSSW_8_0_X. It involves the following packages: FWCore/Framework @cmsbuild, @smuzaffar, @Dr15Jones, @davidlange6 can you please review it and eventually sign? Thanks. Following commands in first line of a comment are recognized
|
|
please test |
|
+1 |
cmsbuild
added
core-approved
fully-signed
and removed
core-pending
pending-signatures
labels
|
The tests are being triggered in jenkins. |
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar |
|
-1 Tested at: 8500b6c ---> test runtestSimCalorimetryHGCalSimProducers had ERRORS you can see the results of the tests here: |
Remove module circular dependency check from EventPrincipal
We previously checked that a module wasn't indirectly calling itself in unscheduled via a run time check. With the requirements on consumes calls, we now check for circular dependencies before running the job. In addition, this implementation would not be thread safe. However, if we ever did need to add back a runtime check we could use the Context information instead.