Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made API to UnscheduledHander const #12811

Merged

Conversation

Dr15Jones
Copy link
Contributor

Changed member functions which would be called from multiple threads simultaneously const in order to distinguish them from the members which are only going to be called serially. This should aid in checking for thread-safety.
A needed followup will be to make Worker thread-safe.

Changed member functions which would be called from multiple threads simultaneously const in order to distinguish them from the members which are only going to be called serially. This should aid in checking for thread-safety.
A needed followup will be to make Worker thread-safe.
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @Dr15Jones (Chris Jones) for CMSSW_8_0_X.

It involves the following packages:

FWCore/Framework

@cmsbuild, @smuzaffar, @Dr15Jones, @davidlange6 can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @wddgit, @wmtan this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

Following commands in first line of a comment are recognized

  • +1|approve[d]|sign[ed]: L1/L2's to approve it
  • -1|reject[ed]: L1/L2's to reject it
  • assign <category>[,<category>[,...]]: L1/L2's to request signatures from other categories
  • unassign <category>[,<category>[,...]]: L1/L2's to remove signatures from other categories
  • hold: L1/all L2's/release manager to mark it as on hold
  • unhold: L1/user who put this PR on hold
  • merge: L1/release managers to merge this request
  • [@cmsbuild,] please test: L1/L2 and selected users to start jenkins tests
  • [@cmsbuild,] please test with cms-sw/cmsdist#<PR>: L1/L2 and selected users to start jenkins tests using externals from cmsdist

@Dr15Jones
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/10329/console

@Dr15Jones
Copy link
Contributor Author

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

@cmsbuild
Copy link
Contributor

-1

Tested at: e7b0182
I found errors in the following unit tests:

---> test runtestRecoLocalCaloHGCalRecProducers had ERRORS
---> test runtestSimCalorimetryHGCalSimProducers had ERRORS

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12811/10329/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
37383df
26a7757
222d08c
6ce2e14
e5d6918
08d667f
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12811/10329/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12811/10329/git-merge-result

davidlange6 added a commit that referenced this pull request Dec 17, 2015
@davidlange6 davidlange6 merged commit 4918827 into cms-sw:CMSSW_8_0_X Dec 17, 2015
@cmsbuild
Copy link
Contributor

@Dr15Jones Dr15Jones deleted the makeUnscheduledHandlerApiConst branch January 6, 2016 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants