Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing connection string to cope with removal of CondDBv1 access #12821

Merged
merged 2 commits into from Dec 19, 2015

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Dec 18, 2015

No description provided.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mmusich (Marco Musich) for CMSSW_8_0_X.

It involves the following packages:

SLHCUpgradeSimulations/Configuration

@cmsbuild, @civanch, @mdhildreth, @davidlange6 can you please review it and eventually sign? Thanks.
@makortel, @Martin-Grunewald this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

Following commands in first line of a comment are recognized

  • +1|approve[d]|sign[ed]: L1/L2's to approve it
  • -1|reject[ed]: L1/L2's to reject it
  • assign <category>[,<category>[,...]]: L1/L2's to request signatures from other categories
  • unassign <category>[,<category>[,...]]: L1/L2's to remove signatures from other categories
  • hold: L1/all L2's/release manager to mark it as on hold
  • unhold: L1/user who put this PR on hold
  • merge: L1/release managers to merge this request
  • [@cmsbuild,] please test: L1/L2 and selected users to start jenkins tests
  • [@cmsbuild,] please test with cms-sw/cmsdist#<PR>: L1/L2 and selected users to start jenkins tests using externals from cmsdist

@@ -23,14 +23,14 @@ def fixDTAlignmentConditions(process):
process.GlobalTag.toGet.extend( cms.VPSet(
cms.PSet(record = cms.string("DTAlignmentErrorExtendedRcd"),
tag = cms.string("MuonDTAPEObjectsExtended_v0_mc"),
connect = cms.string("frontier://FrontierProd/CMS_COND_ALIGN_000")
connect = cms.string("frontier://FrontierProd/CMS_CONDITIONS")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this could be dropped: the tag is already in use in all MC GT:

80X_mcRun1_design_Queue Queue   DTAlignmentErrorExtendedRcd -   MuonDTAPEObjectsExtended_v0_mc
80X_mcRun1_HeavyIon_Queue   Queue   DTAlignmentErrorExtendedRcd -   MuonDTAPEObjectsExtended_v0_mc
80X_mcRun1_pA_Queue Queue   DTAlignmentErrorExtendedRcd -   MuonDTAPEObjectsExtended_v0_mc
80X_mcRun1_realistic_Queue  Queue   DTAlignmentErrorExtendedRcd -   MuonDTAPEObjectsExtended_v0_mc
80X_mcRun2_asymptotic_Queue Queue   DTAlignmentErrorExtendedRcd -   MuonDTAPEObjectsExtended_v0_mc
80X_mcRun2_design_Queue Queue   DTAlignmentErrorExtendedRcd -   MuonDTAPEObjectsExtended_v0_mc
80X_mcRun2_HeavyIon_Queue   Queue   DTAlignmentErrorExtendedRcd -   MuonDTAPEObjectsExtended_v0_mc
80X_mcRun2_startup_Queue    Queue   DTAlignmentErrorExtendedRcd -   MuonDTAPEObjectsExtended_v0_mc
76X_upgrade2017_design_Queue    Queue   DTAlignmentErrorExtendedRcd -   MuonDTAPEObjectsExtended_v0_mc

@diguida
Copy link
Contributor

diguida commented Dec 18, 2015

as you can see, some of the customisations are actually not needed. Can you please tell us which is the "reference" GT you customise?

@mmusich
Copy link
Contributor Author

mmusich commented Dec 18, 2015

@diguida thanks for pointing out. Actually is impossible to tell what needs to be dropped unless we know the GT that is used to start from @lgray

@diguida
Copy link
Contributor

diguida commented Dec 18, 2015

@mmusich thanks! That's indeed the ratio of the question in #12821 (comment)
I hope our upgrade friends can give us the response :-)

@cmsbuild
Copy link
Contributor

Pull request #12821 was updated. @cmsbuild, @civanch, @mdhildreth, @davidlange6 can you please check and sign again.

@mmusich
Copy link
Contributor Author

mmusich commented Dec 18, 2015

removed some more obsolete connections.

@lgray
Copy link
Contributor

lgray commented Dec 18, 2015

@diguida @mmusich I am starting from the auto_cond.py global tag auto:run2_mc, since the geometry being used (for now) is the run2 detector with HGCal substituted in.

The only payload "correction" added is the one for the RPCs.

Here's the configuration for the test that is failing:
https://github.com/cms-sw/cmssw/blob/CMSSW_8_0_X/RecoLocalCalo/HGCalRecProducers/test/testHGCalRecoLocal_cfg.py#L86

@mmusich
Copy link
Contributor Author

mmusich commented Dec 18, 2015

@lgray thanks! we figured it out in the meanwhile. We kept for the time being the RPC customization, but remove the DT and CSC stuff that is already available in any Run2 MC GT and Queue. Will need to clean up a bit https://github.com/cms-sw/cmssw/search?utf8=%E2%9C%93&q=fixCSCAlignmentConditions&type=Code and https://github.com/cms-sw/cmssw/search?utf8=%E2%9C%93&q=fixDTAlignmentConditions&type=Code

@cmsbuild
Copy link
Contributor

Pull request #12821 was updated. @cmsbuild, @civanch, @mdhildreth, @davidlange6 can you please check and sign again.

@lgray
Copy link
Contributor

lgray commented Dec 18, 2015

@mmusich @diguida I can confirm the changes you have so far fixes my problem. Thanks!

davidlange6 added a commit that referenced this pull request Dec 19, 2015
Fixing connection string to cope with removal of CondDBv1 access
@davidlange6 davidlange6 merged commit 48596ec into cms-sw:CMSSW_8_0_X Dec 19, 2015
@lgray
Copy link
Contributor

lgray commented Dec 19, 2015

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants