New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing connection string to cope with removal of CondDBv1 access #12821
Conversation
A new Pull Request was created by @mmusich (Marco Musich) for CMSSW_8_0_X. It involves the following packages: SLHCUpgradeSimulations/Configuration @cmsbuild, @civanch, @mdhildreth, @davidlange6 can you please review it and eventually sign? Thanks. Following commands in first line of a comment are recognized
|
@@ -23,14 +23,14 @@ def fixDTAlignmentConditions(process): | |||
process.GlobalTag.toGet.extend( cms.VPSet( | |||
cms.PSet(record = cms.string("DTAlignmentErrorExtendedRcd"), | |||
tag = cms.string("MuonDTAPEObjectsExtended_v0_mc"), | |||
connect = cms.string("frontier://FrontierProd/CMS_COND_ALIGN_000") | |||
connect = cms.string("frontier://FrontierProd/CMS_CONDITIONS") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this could be dropped: the tag is already in use in all MC GT:
80X_mcRun1_design_Queue Queue DTAlignmentErrorExtendedRcd - MuonDTAPEObjectsExtended_v0_mc
80X_mcRun1_HeavyIon_Queue Queue DTAlignmentErrorExtendedRcd - MuonDTAPEObjectsExtended_v0_mc
80X_mcRun1_pA_Queue Queue DTAlignmentErrorExtendedRcd - MuonDTAPEObjectsExtended_v0_mc
80X_mcRun1_realistic_Queue Queue DTAlignmentErrorExtendedRcd - MuonDTAPEObjectsExtended_v0_mc
80X_mcRun2_asymptotic_Queue Queue DTAlignmentErrorExtendedRcd - MuonDTAPEObjectsExtended_v0_mc
80X_mcRun2_design_Queue Queue DTAlignmentErrorExtendedRcd - MuonDTAPEObjectsExtended_v0_mc
80X_mcRun2_HeavyIon_Queue Queue DTAlignmentErrorExtendedRcd - MuonDTAPEObjectsExtended_v0_mc
80X_mcRun2_startup_Queue Queue DTAlignmentErrorExtendedRcd - MuonDTAPEObjectsExtended_v0_mc
76X_upgrade2017_design_Queue Queue DTAlignmentErrorExtendedRcd - MuonDTAPEObjectsExtended_v0_mc
as you can see, some of the customisations are actually not needed. Can you please tell us which is the "reference" GT you customise? |
@mmusich thanks! That's indeed the ratio of the question in #12821 (comment) |
Pull request #12821 was updated. @cmsbuild, @civanch, @mdhildreth, @davidlange6 can you please check and sign again. |
removed some more obsolete connections. |
@diguida @mmusich I am starting from the auto_cond.py global tag The only payload "correction" added is the one for the RPCs. Here's the configuration for the test that is failing: |
@lgray thanks! we figured it out in the meanwhile. We kept for the time being the RPC customization, but remove the DT and CSC stuff that is already available in any Run2 MC GT and Queue. Will need to clean up a bit https://github.com/cms-sw/cmssw/search?utf8=%E2%9C%93&q=fixCSCAlignmentConditions&type=Code and https://github.com/cms-sw/cmssw/search?utf8=%E2%9C%93&q=fixDTAlignmentConditions&type=Code |
b866d11
to
bf8fdf4
Compare
Pull request #12821 was updated. @cmsbuild, @civanch, @mdhildreth, @davidlange6 can you please check and sign again. |
Fixing connection string to cope with removal of CondDBv1 access
Thanks! |
No description provided.