Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop EcalCalPi0Calib from tests. #1285

Merged
merged 2 commits into from Nov 5, 2013
Merged

Conversation

ktf
Copy link
Contributor

@ktf ktf commented Nov 1, 2013

@ktf
Copy link
Contributor Author

ktf commented Nov 1, 2013

@demattia this is the correct one...

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 1, 2013

A new Pull Request was created by @ktf (Giulio Eulisse) for CMSSW_7_0_X.

Drop EcalCalPi0Calib from tests.

It involves the following packages:

Configuration/AlCa

@demattia, @nclopezo, @rcastello can you please review it and eventually sign? Thanks.
@ghellwig this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@ktf you are the release manager for this.

@demattia
Copy link
Contributor

demattia commented Nov 1, 2013

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 1, 2013

This pull request is fully signed and it will be integrated in one of the next IBs unless changes or unless it breaks tests. @ktf can you please take care of it?

@ktf
Copy link
Contributor Author

ktf commented Nov 1, 2013

actually this still fails my test. Can you look if that's actually what is used?

@demattia
Copy link
Contributor

demattia commented Nov 1, 2013

Hi Giulio,

would it be possible to have the configuration file and the way to reproduce it?

Thanks,

Marco


Marco De Mattia
Purdue University
e-mail: marco.de.mattia@cern.chmailto:marco.de.mattia@cern.ch
website:http://demattia.web.cern.ch/demattia/

On Nov 1, 2013, at 9:00 PM, Giulio Eulisse <notifications@github.commailto:notifications@github.com> wrote:

actually this still fails my test. Can you look if that's actually what is used?


Reply to this email directly or view it on GitHubhttps://github.com//pull/1285#issuecomment-27596428.

@ktf
Copy link
Contributor Author

ktf commented Nov 2, 2013

runTheMatrix.py -l 11.0 --useInput=all

@ktf
Copy link
Contributor Author

ktf commented Nov 5, 2013

Agreed by Fede. @rcastello @demattia shout if not ok.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 5, 2013

Pull request #1285 was updated. @demattia, @cmsbuild, @nclopezo, @rcastello can you please check and sign again.

ktf added a commit that referenced this pull request Nov 5, 2013
AlCa Fix -- Drop EcalCalPi0Calib & EcalCalEtaCalib from tests.
@ktf ktf merged commit 7b131f1 into cms-sw:CMSSW_7_0_X Nov 5, 2013
@ktf ktf deleted the drop-EcalCalPi0Calib branch November 5, 2013 00:58
ktf added a commit to ktf/cmssw that referenced this pull request Nov 5, 2013
This is required to fix a crash in workflow 11, due to the fact
there are two paths now. See also cms-sw#1278, cms-sw#1285.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants