[RFC] Fix logical not in HLTHiggsPlotter::analyze #12880
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
logical not is applied to unsigned int, which is a mistake:
HLTriggerOffline/Higgs/src/HLTHiggsPlotter.cc:217:27: warning:
logical not is only applied to the left hand side of comparison
[-Wlogical-not-parentheses]
HLTriggerOffline/Higgs/src/HLTHiggsPlotter.cc:217:27: warning:
comparison of constant '6' with boolean expression is always false
[-Wbool-compare]
HLTriggerOffline/Higgs/src/HLTHiggsPlotter.cc:224:23: warning:
logical not is only applied to the left hand side of comparison
[-Wlogical-not-parentheses]
HLTriggerOffline/Higgs/src/HLTHiggsPlotter.cc:224:23: warning:
comparison of constant '6' with boolean expression is always false
[-Wbool-compare]
The patch attempts to resolve it.
Signed-off-by: David Abdurachmanov <David.Abdurachmanov@cern.ch>
|
A new Pull Request was created by @davidlt for CMSSW_8_0_X. It involves the following packages: HLTriggerOffline/Higgs @cmsbuild, @vanbesien, @deguio, @davidlange6 can you please review it and eventually sign? Thanks. Following commands in first line of a comment are recognized
|
|
ping^1 |
|
I would ask @jasperlauwers to review the logic before approving. |
|
Please continue with the PR. |
|
+1 |
cmsbuild
added
dqm-approved
fully-signed
and removed
dqm-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar |
|
+1 |
cmsbuild
added a commit
that referenced
this pull request
Jan 19, 2016
[RFC] Fix logical not in HLTHiggsPlotter::analyze
cmsbuild
added a commit
that referenced
this pull request
Jan 19, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
logical not is applied to unsigned int, which is a mistake:
The patch attempts to resolve it.
I am not sure if logical not should be applied only to
objType == EVTColContainer::PFJETor a full condition in if-statement. My current assumption is that author intended to apply this forobjType == EVTColContainer::PFJETonly. This is why it's marked as RFC.Signed-off-by: David Abdurachmanov David.Abdurachmanov@cern.ch