Fix ownership problem in TMVAEvaluator (76X) #13003
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The TMVAEvaluator was meant to own the GBRForest if the TMVAEvaluator made the instance itself else it was not supposed to own it if it was given a GBRForest externally. However, for both cases the code used an std::unique_ptr and attempted to call 'release' in the case of non-ownership. The problem was multiple calls to initializeGBRForest still caused the code to delete a GBRForest which was not supposed to be owned. The code was changed to use an std::shared_ptr where we use a custom deallocator in the case of non-ownership (the deallocator does nothing). This problem was found in the IB RelVals.
|
A new Pull Request was created by @ferencek (Dinko Ferenček) for CMSSW_7_6_X. It involves the following packages: CommonTools/Utils @cvuosalo, @monttj, @cmsbuild, @slava77, @vadler, @davidlange6 can you please review it and eventually sign? Thanks. Following commands in first line of a comment are recognized
|
|
@cmsbuild please test |
|
The tests are being triggered in jenkins. |
davidlange6
added a commit
that referenced
this pull request
Jan 22, 2016
…lem-from-CMSSW_7_6_3 Fix ownership problem in TMVAEvaluator (76X)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #12675