use QIEType instead of old transient qieIndex

[kpedro88]

Following up on #12905, the QIE shape (ADC ladder) should be determined by the new QIEType database parameter.

Attn: @walterjr, @abdoulline

[cmsbuild]

A new Pull Request was created by @kpedro88 (Kevin Pedro) for CMSSW_8_0_X.

It involves the following packages:

CalibCalorimetry/HcalAlgos
CalibFormats/HcalObjects
CondFormats/HcalObjects

@diguida, @cerminar, @cmsbuild, @franzoni, @ggovi, @mmusich, @davidlange6 can you please review it and eventually sign? Thanks.
@apfeiffer1, @tocheng this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

Following commands in first line of a comment are recognized

• +1|approve[d]|sign[ed]: L1/L2's to approve it
• -1|reject[ed]: L1/L2's to reject it
• assign <category>[,<category>[,...]]: L1/L2's to request signatures from other categories
• unassign <category>[,<category>[,...]]: L1/L2's to remove signatures from other categories
• hold: L1/all L2's/release manager to mark it as on hold
• unhold: L1/user who put this PR on hold
• merge: L1/release managers to merge this request
• [@cmsbuild,] please test: L1/L2 and selected users to start jenkins tests
• [@cmsbuild,] please test with cms-sw/cmsdist#<PR>: L1/L2 and selected users to start jenkins tests using externals from cmsdist

[lgray]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/10605/console
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/10606/console

[cmsbuild]

+1
Tested at: 3af11c3
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13004/10606/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
8883c03
8b63340
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13004/10606/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13004/10606/git-merge-result

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13004/10606/summary.html

[kpedro88]

The comparison looks good to me. No changes expected or observed. @mmusich, @diguida, @ggovi can you take a look?

[mmusich]

+1

• code changes in line with description
• no differences observed in the comparison with baseline

[abdoulline]

@ggovi
Giacomo, may I draw your attention to this PR (approval)?

[ggovi]

@abdoulline
Not sure about the aim to remove the data member mQIEIndex. However, it is was a transient one, so it should work.Did you explicitly try to read existing data with this class?

[kpedro88]

@ggovi - several of the matrix tests use existing data, and none of the comparisons show any problems.

[ggovi]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar