Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pp RECO with HI photon isolation using "customise" option #13047

Merged
merged 1 commit into from Jan 29, 2016

Conversation

ttrk
Copy link
Contributor

@ttrk ttrk commented Jan 24, 2016

This PR adds the HI-style isolation to the pp photon sequences. Heavy Ions needs this information during the pp reference run in order to do proper comparisons to PbPb results, where this information will be used for photon ID.

It will add two instances of the HIPhotonIsolation ValueMap, one for "std" photons and another for GED photons to the RECO and AOD event content for pp events.

This PR was suggested by @davidlange6 in the relevant PR for 76X : #12262
see comment : #12262 (comment)

@richard-cms
@yenjie

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @ttrk for CMSSW_8_0_X.

It involves the following packages:

RecoHI/Configuration
RecoHI/HiEgammaAlgos

@cmsbuild, @cvuosalo, @davidlange6, @slava77 can you please review it and eventually sign? Thanks.
@MiheeJo, @jazzitup, @richard-cms, @echapon, @yenjie, @kurtejung, @istaslis, @mandrenguyen, @dgulhan, @yetkinyilmaz this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@slava77
Copy link
Contributor

slava77 commented Jan 25, 2016

@cmsbuild please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/10704/console

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@cvuosalo
Copy link
Contributor

+1

For #13047 de90e22

For Heavy Ions, adding HI-style isolation to the pp photon sequences. #12262 is the matching 76X version of this PR, and it was approved but never merged.

The code changes are satisfactory, and Jenkins tests against baseline CMSSW_8_0_X_2016-01-22-2300 show no significant differences.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request Jan 29, 2016
pp RECO with HI photon isolation using "customise" option
@cmsbuild cmsbuild merged commit 471f6c6 into cms-sw:CMSSW_8_0_X Jan 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants