Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Iso-filter RBX Cluster Cut Retuning #13050

Merged
merged 4 commits into from Jan 29, 2016

Conversation

dertexaner
Copy link
Contributor

This is a PR to reduce anomalous misID rate of the iso-filter in very energetic (􏰀 1 TeV), late showering, neutral jets which could occasionally produce HCAL clusters that are misidentified as “noisy isolated RBX clusters” due to small corresponding energy deposits in ECAL and very few tracks.
The set of "relative isolation cuts" on the RBX clusters has been turned into a set of "absolute isolation cuts" for clusters with energies greater than 500 GeV.
This is expected to minimally affect the filter performance, whereas it has been verified to reduce the misID rate by an order of magnitude in 13 TeV QCD events (see tail of attached plot, >
1 TeV ).

dn-15-028_plots___qcd_pt-15to7000_13tev_runiispring15dr74_v14d_dnplotsmaker_filtermetperformance_

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @dertexaner for CMSSW_8_0_X.

It involves the following packages:

RecoLocalCalo/HcalRecProducers

@cmsbuild, @cvuosalo, @davidlange6, @slava77 can you please review it and eventually sign? Thanks.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@slava77
Copy link
Contributor

slava77 commented Jan 25, 2016

@cmsbuild please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/10727/console

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

if( isolhcale<TightHcalIsol_*RBXEneThreshold_ && isolecale<TightEcalIsol_*RBXEneThreshold_ && isoltrke<TightTrackIsol_*RBXEneThreshold_ )
isTightIso=true;
}
if( ene<=RBXEneThreshold_ ){// Old relative iso-cut for low energy RBX clusters
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add sanity check to if statement: && ene > 0.0

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@cmsbuild
Copy link
Contributor

Pull request #13050 was updated. @cmsbuild, @cvuosalo, @davidlange6, @slava77 can you please check and sign again.

@cvuosalo
Copy link
Contributor

@cmsbuild please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/10786/console

@slava77
Copy link
Contributor

slava77 commented Jan 28, 2016

@cmsbuild please test
looks like the last build tripped over the github availability issues

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/10791/console

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@cvuosalo
Copy link
Contributor

+1

For #13050 2c44160

Re-tuning RBX cluster cut for HCAL iso filter to fix anomalous mis-ID rate.

The code changes are satisfactory, and Jenkins tests against baseline CMSSW_8_0_X_2016-01-26-1100 show no significant differences.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request Jan 29, 2016
@cmsbuild cmsbuild merged commit c057e65 into cms-sw:CMSSW_8_0_X Jan 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants